@mattab opened this Issue on June 12th 2014 Member

The Provider plugin is currently part of core Piwik platform.

Let's move it to the Marketplace instead.

  • Remove plugin from core
  • Move file to the marketplace
  • On upgrade:
    • if Provider plugin is disabled, then delete Provider files.
    • if Provider plugin is enabled, make sure it still works and that the plugin can be later upgraded to latest marketplace version
@tsteur commented on July 25th 2014 Member

There is some code used of the Provider plugin used for instance in https://github.com/piwik/piwik/blob/master/plugins/Live/Visitor.php#L105 . I'd suggest to trigger an event to let the Provider plugin add those columns? Would also allow other plugins to add more information there.

Provider::getCleanHostname is used in the UserCountry plugin but there is already a check whether the Provider plugin is installed.

Translations should be moved from lang/en.json to the plugin see #5863 . Problem is those Provider translation keys are used for instance in multiple Live plugin templates. To solve this there could be another event as well but makes it rather complicated. Another possibility would be to move those keys to another plugin but not sure if we fix the actual issue then (which is I think more or less let plugins add custom data to the Live plugin API and UI)

@mattab commented on August 3rd 2014 Member

I'd suggest to trigger an event to let the Provider plugin add those columns? Would also allow other plugins to add more information there.

and

not sure if we fix the actual issue then (which is I think more or less let plugins add custom data to the Live plugin API and UI)

+1, let's use this refactoring as opportunity to improve Live plugin hook-ability. Even if we don't finish the refactor, at least the hook will be re-usable by other plugins!

@mattab commented on June 11th 2015 Member

it will be useful to have this plugin in the marketplace, because most users don't need this feature and it can impact performance significantly (slow reverse dns query). Moving to 3.0.0.

@axle07 commented on November 1st 2018

What is the name of this plugin in the marketplace?

@sgiehl commented on November 1st 2018 Member

@axle07 It has not been moved yet, so it's still included in core

@axle07 commented on November 1st 2018

We've enabled the Provider plugin in config.ini.php, and have the MaxMind ISP database, but are getting an empty array from Provider.getProvider. Are there more steps to activating the plugin?

Powered by GitHub Issue Mirror