Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Provider plugin to the Marketplace #5341

Closed
mattab opened this issue Jun 12, 2014 · 6 comments · Fixed by #15552
Closed

Move Provider plugin to the Marketplace #5341

mattab opened this issue Jun 12, 2014 · 6 comments · Fixed by #15552
Assignees
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Jun 12, 2014

The Provider plugin is currently part of core Piwik platform.

Let's move it to the Marketplace instead.

  • Remove plugin from core
  • Move file to the marketplace
  • On upgrade:
    • if Provider plugin is disabled, then delete Provider files.
    • if Provider plugin is enabled, make sure it still works and that the plugin can be later upgraded to latest marketplace version
@mattab mattab added this to the 2.5.0 - Piwik 2.5.0 milestone Jul 8, 2014
@tsteur
Copy link
Member

tsteur commented Jul 25, 2014

There is some code used of the Provider plugin used for instance in https://github.com/piwik/piwik/blob/master/plugins/Live/Visitor.php#L105 . I'd suggest to trigger an event to let the Provider plugin add those columns? Would also allow other plugins to add more information there.

Provider::getCleanHostname is used in the UserCountry plugin but there is already a check whether the Provider plugin is installed.

Translations should be moved from lang/en.json to the plugin see #5863 . Problem is those Provider translation keys are used for instance in multiple Live plugin templates. To solve this there could be another event as well but makes it rather complicated. Another possibility would be to move those keys to another plugin but not sure if we fix the actual issue then (which is I think more or less let plugins add custom data to the Live plugin API and UI)

@mattab
Copy link
Member Author

mattab commented Aug 3, 2014

I'd suggest to trigger an event to let the Provider plugin add those columns? Would also allow other plugins to add more information there.

and

not sure if we fix the actual issue then (which is I think more or less let plugins add custom data to the Live plugin API and UI)

+1, let's use this refactoring as opportunity to improve Live plugin hook-ability. Even if we don't finish the refactor, at least the hook will be re-usable by other plugins!

@mattab
Copy link
Member Author

mattab commented Jun 11, 2015

it will be useful to have this plugin in the marketplace, because most users don't need this feature and it can impact performance significantly (slow reverse dns query). Moving to 3.0.0.

@mattab mattab added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Oct 1, 2015
@mattab mattab mentioned this issue Oct 17, 2015
27 tasks
@mattab mattab removed the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Feb 8, 2016
@axle07
Copy link

axle07 commented Nov 1, 2018

What is the name of this plugin in the marketplace?

@sgiehl
Copy link
Member

sgiehl commented Nov 1, 2018

@axle07 It has not been moved yet, so it's still included in core

@axle07
Copy link

axle07 commented Nov 1, 2018

We've enabled the Provider plugin in config.ini.php, and have the MaxMind ISP database, but are getting an empty array from Provider.getProvider. Are there more steps to activating the plugin?

@mattab mattab added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants