Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Piwik + HHVM: htmlspecialchars() #5335

Closed
anonymous-matomo-user opened this issue Jun 11, 2014 · 1 comment
Closed

Piwik + HHVM: htmlspecialchars() #5335

anonymous-matomo-user opened this issue Jun 11, 2014 · 1 comment
Labels
answered For when a question was asked and we referred to forum or answered it. Bug For errors / faults / flaws / inconsistencies etc.
Milestone
Backlog (Help wan...

Comments

@anonymous-matomo-user
Copy link

Hi,

We are currently trying to run Piwik with HHVM.

Archiving already works great with changes from [5263].

Currently we loose a lot of special chars in the UI due to htmlspecialchars() eating some UTF-8. It comes down to differences in handling ENT_IGNORE between PHP and HHVM. Replacing ENT_IGNORE with ENT_SUBSTITUTE in core/DataTable/Filter/SafeDecodeLabel.php line 46 resolves this issue.

Although I guess this is more of a HHVM problem than a Piwik problem, the comments in core/DataTable/Filter/SafeDecodeLabel.php suggest that this change is already thought of in Piwik.

We are using nginx + php 5.3 / HHVM 3.1.0.
@anonymous-matomo-user anonymous-matomo-user added this to the 2.5.0 - Piwik 2.5.0 milestone Jul 8, 2014
@mattab
Copy link
Member

mattab commented Dec 1, 2014

Hello,

maybe HHVM has fixed this issue already, but anyway let's revisit when we do: #4415

@mattab mattab closed this as completed Dec 1, 2014
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Dec 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
answered For when a question was asked and we referred to forum or answered it. Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
2 participants
@mattab @anonymous-matomo-user