Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Piwik 2.3.0] Error in DataTable footer drawer #5332

Closed
mgazdzik opened this issue Jun 10, 2014 · 3 comments
Closed

[Piwik 2.3.0] Error in DataTable footer drawer #5332

mgazdzik opened this issue Jun 10, 2014 · 3 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@mgazdzik
Copy link
Contributor

It seems that there is bug with displaying drawer content after expanding one of subtables.
Steps to reproduce:

This problem does not occur when no rows are expanded.

@mgazdzik
Copy link
Contributor Author

One important note - you have to set row limit to 500 (it's not passed with URL)

@mattab
Copy link
Member

mattab commented Jun 12, 2014

Thanks for the report! we should fix that one

@tsteur
Copy link
Member

tsteur commented Jun 20, 2014

In f350d55: fixes #5332 remove all event listeners on the drawer before adding the new one

otherwise on every subtable click the event listener will be added again and again resulting in executing multiple times. If the event listener is added twice the drawer will quickly open and close again. Fixed a similar bug recently and there might be more such issues in dataTable.js ...

@mgazdzik mgazdzik added this to the 2.4.0 - Piwik 2.4.0 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

3 participants