Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Visitor Profile log tooltip #5313

Closed
anonymous-matomo-user opened this issue Jun 6, 2014 · 2 comments
Closed

Change Visitor Profile log tooltip #5313

anonymous-matomo-user opened this issue Jun 6, 2014 · 2 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@anonymous-matomo-user
Copy link

The details tooltip on the Visitor Profile should be the same as the black one on the Visitor Log.
It is displayed with wrong line-breaks.

Piwik v2.3.0

Steps to reproduce:

  • Visitors > Visitor Log
  • View visitor profile > Visited pages
  • mouseover rows and wait to display tooltip
@anonymous-matomo-user
Copy link
Author

Attachment:
Piwik-2.3.0_profile_tooltip.png

@anonymous-matomo-user anonymous-matomo-user added this to the 2.5.0 - Piwik 2.5.0 milestone Jul 8, 2014
@fvdm
Copy link

fvdm commented Jul 14, 2014

In the javascript this tooltip section from plugins/Live/javascripts/visitorLog.js is missing in plugins/Live/javascripts/visitorProfile.js.

I'm on a phone now so I can't test my theory, but I think this is the problem.

                    var $this = $(this);
                    var tooltipIsOpened = false;

                    $('a', $this).on('focus', function () {
                        // see https://github.com/piwik/piwik/issues/4099
                        if (tooltipIsOpened) {
                            $this.tooltip('close');
                        }
                    });

                    $this.tooltip({
                        track: true,
                        show: false,
                        hide: false,
                        content: function() {
                            var title = $(this).attr('title');
                            return $('<a>').text( title ).html().replace(/\n/g, '<br />');
                        },
                        tooltipClass: 'small',
                        open: function() { tooltipIsOpened = true; },
                        close: function() { tooltipIsOpened = false; }
                    });

@tsteur tsteur closed this as completed in 2191368 Jul 25, 2014
@tsteur tsteur self-assigned this Jul 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

3 participants