Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove plugins/Zeitigeist/* plugin from filesystem on upgrade #5297

Closed
hpvd opened this issue Jun 4, 2014 · 6 comments
Closed

Remove plugins/Zeitigeist/* plugin from filesystem on upgrade #5297

hpvd opened this issue Jun 4, 2014 · 6 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@hpvd
Copy link

hpvd commented Jun 4, 2014

... the old Piwik logo is back 8-)
Cache cleaning, deactivation of ZEN-mode Plugin etc doesn't help.
The old one stays forever...

Please see attachment

What have I done?

  • Activated Zen-Mode Plugin
  • brows around and unfold fold "ZEN-head" several times to watch what changes
    and uups it was there

Piwik 2.4b3

@hpvd
Copy link
Author

hpvd commented Jun 4, 2014

Attachment:
2014-06-04_21h38_31.png

@mattab
Copy link
Member

mattab commented Jun 5, 2014

The plugins/Zeitgeist/ directory should have been removed when you upgraded to 2.4.0 beta https://github.com/piwik/piwik/blob/master/core/Updates/2.4.0-b3.php

@tsteur If deleting the files didn't work during upgrade (eg. if files are not writable by webserver users), maybe we could show a "notification" in the user interface, asking user to manually remove plugins/Zeitgeist?

@hpvd
Copy link
Author

hpvd commented Jun 5, 2014

manually removing the plugin/zeitgeist folder brings new Logo back and gives a message:

Warning: The following plugins are not compatible with Piwik 2.4.0-b3 and could not be loaded: Zeitgeist.You can update or uninstall these plugins on the Manage Plugins page.

after clicking uninstall in the plugin manage table everything is fine :-)

@tsteur
Copy link
Member

tsteur commented Jun 5, 2014

In 5c19284: refs #5297 make sure plugin is deactivated before uninstalling

@tsteur
Copy link
Member

tsteur commented Jun 5, 2014

In c53dbe7: refs #5297 make sure plugin is deactivated even for users updating from 2.4.0-b3 to b4

@tsteur
Copy link
Member

tsteur commented Jun 5, 2014

In this case it was most likely rather the case that hpvd updated from beta1 to beta3 or from beta2 to beta3. I didn't wanna handle this case as I thought there was no big time difference between those releases.

In beta1 we deactivated Zeitgeist during update but did not uninstall it yet. In beta3 during update we uninstalled it. The uninstall, which is supposed to remove files, does not work if the plugin is active which could be the case after updating to beta1.

I think this is rather the case especially since it works for hpvd to remove it using the UI. So there must be permission for it. I will now make sure it works even for people updating from beta3 to beta4 :)

Nonetheless it might be worth showing a notification in case there are no permissions. Although I am not sure how an update would work in general when there are no file permissions?

@hpvd hpvd added this to the 2.4.0 - Piwik 2.4.0 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

3 participants