New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove plugins/Zeitigeist/* plugin from filesystem on upgrade #5297
Comments
Attachment: |
The plugins/Zeitgeist/ directory should have been removed when you upgraded to 2.4.0 beta https://github.com/piwik/piwik/blob/master/core/Updates/2.4.0-b3.php @tsteur If deleting the files didn't work during upgrade (eg. if files are not writable by webserver users), maybe we could show a "notification" in the user interface, asking user to manually remove plugins/Zeitgeist? |
manually removing the plugin/zeitgeist folder brings new Logo back and gives a message:
after clicking uninstall in the plugin manage table everything is fine :-) |
In this case it was most likely rather the case that hpvd updated from beta1 to beta3 or from beta2 to beta3. I didn't wanna handle this case as I thought there was no big time difference between those releases. In beta1 we deactivated Zeitgeist during update but did not uninstall it yet. In beta3 during update we uninstalled it. The uninstall, which is supposed to remove files, does not work if the plugin is active which could be the case after updating to beta1. I think this is rather the case especially since it works for hpvd to remove it using the UI. So there must be permission for it. I will now make sure it works even for people updating from beta3 to beta4 :) Nonetheless it might be worth showing a notification in case there are no permissions. Although I am not sure how an update would work in general when there are no file permissions? |
... the old Piwik logo is back 8-)
Cache cleaning, deactivation of ZEN-mode Plugin etc doesn't help.
The old one stays forever...
Please see attachment
What have I done?
and uups it was there
Piwik 2.4b3
The text was updated successfully, but these errors were encountered: