Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove token_auth from archive.log #5277

Closed
anonymous-matomo-user opened this issue Jun 2, 2014 · 7 comments
Closed

Remove token_auth from archive.log #5277

anonymous-matomo-user opened this issue Jun 2, 2014 · 7 comments
Assignees
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@anonymous-matomo-user
Copy link

When an error message is written to the archive.log, the token_auth is also written to the log file. For security reasons, I wish to suppress this information.

@mattab
Copy link
Member

mattab commented Jun 2, 2014

Thanks for the suggestion, I think this makes sense! Maybe we can replace token_auth=XYZ by token_auth=REMOVED

@anonymous-matomo-user anonymous-matomo-user added this to the 2.5.0 - Piwik 2.5.0 milestone Jul 8, 2014
@mattab mattab removed the P: normal label Aug 3, 2014
@mattab mattab added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Oct 12, 2014
@mnapoli
Copy link
Contributor

mnapoli commented Feb 25, 2015

archive.log is not a piwik log file, it's probably where you redirect the output of the cron command?

@mattab
Copy link
Member

mattab commented Feb 27, 2015

@mnapoli users can configure piwik to log the last core:archive output to this archive.log or another file

maybe it would be fixed with #7301

@mnapoli
Copy link
Contributor

mnapoli commented Mar 1, 2015

@mnapoli users can configure piwik to log the last core:archive output to this archive.log or another file

In the link I only see redirecting the output of the command to a file, is that what you mean?

We could have a look at passing the token_auth not in the URL maybe? E.g. as a header. The URL parameter could still be used but at least for correct setups the token would be passed as a header and never be logged, either in Piwik's output or also Apache access logs, etc...

@mattab
Copy link
Member

mattab commented Mar 4, 2015

In the link I only see redirecting the output of the command to a file, is that what you mean?

Yes

We could have a look at passing the token_auth not in the URL maybe? E.g. as a header. The URL parameter could still be used but at least for correct setups the token would be passed as a header and never be logged, either in Piwik's output or also Apache access logs, etc...

good idea, I created issue: #7349

@mnapoli is this issue fixed?

@mnapoli
Copy link
Contributor

mnapoli commented Mar 4, 2015

@mnapoli is this issue fixed?

Not totally, see for example https://github.com/piwik/piwik/blob/frontcontroller-refactoring/core/CronArchive.php#L825-833

In most case the archiver will use the logger, so it means the current issue is addressed. But in some cases it does print… So that need to be fixed.

It will be an easy fix, I'm moving it to 2.12.

@mnapoli mnapoli modified the milestones: Piwik 2.12.0, Short term Mar 4, 2015
@mattab
Copy link
Member

mattab commented Mar 4, 2015

👍

@mnapoli mnapoli closed this as completed Mar 4, 2015
@mnapoli mnapoli self-assigned this Mar 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

3 participants