Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CustomEvent in Visitor Profil: Prevent linebreak after event symbol #5233

Closed
hpvd opened this issue May 26, 2014 · 8 comments
Closed

CustomEvent in Visitor Profil: Prevent linebreak after event symbol #5233

hpvd opened this issue May 26, 2014 · 8 comments
Assignees
@tsteur
Labels
Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
Piwik 2.11.0

Comments

@hpvd
Copy link

hpvd commented May 26, 2014

There is a not necessary line break in the Visitor Log directly after the event symbol.
Please see attachment

seen in
2.3.0 final, FF30
@hpvd
Copy link
Author

hpvd commented May 26, 2014

Attachment:
2014-05-26_07h35_33.png

@hpvd
Copy link
Author

hpvd commented Jun 15, 2014

still exists in Piwik 2.4beta6 and FF30final and also FF31beta

@hpvd hpvd added this to the 2.5.0 - Piwik 2.5.0 milestone Jul 8, 2014
@mattab mattab removed the P: normal label Aug 3, 2014
@mattab
Copy link
Member

mattab commented Dec 1, 2014

Hi @hpvd can you reproduce this issue in 2.9.1? it seems to work here

@hpvd
Copy link
Author

hpvd commented Dec 1, 2014

can still be reproduced with piwik 2.10b2 and FF34 in visitor profile.
In the visitorlog everything looks great.

In addition there are now 2 kinds of this in visitor profile:

  1. line-break after event symbol
  2. no line-break but to low position of event symbol
    2014-12-01_22h28_55

please see attachment

@tsteur tsteur added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Feb 5, 2015
@tsteur
Copy link
Member

tsteur commented Feb 5, 2015

I can confirm the line break is still a problem with latest Piwik when event category is very long. Also the arrow is not correctly placed (not centered)

tsteur added a commit that referenced this issue Feb 5, 2015
@tsteur
refs #5233 prevent line break after event icon and fix position of ev…
dd76c9f 
…ent icon
@tsteur tsteur mentioned this issue Feb 5, 2015
Merged
@tsteur tsteur self-assigned this Feb 5, 2015
@tsteur tsteur modified the milestones: Piwik 2.11.0, Short term Feb 5, 2015
@mattab mattab closed this as completed Feb 9, 2015
@hpvd
Copy link
Author

hpvd commented Feb 11, 2015

still there in piwik 2.11 b4 (latest FF36, Opera 27.0)
2015-02-11_08h23_21

@mattab
Copy link
Member

mattab commented Feb 12, 2015

Reopening as per @hpvd feedback.

@mattab mattab reopened this Feb 12, 2015
tsteur added a commit that referenced this issue Feb 13, 2015
@tsteur
refs #5233 CustomEvent in Visitor Profil: Prevent linebreak after eve…
0de03d4 
…nt symbol
@tsteur
Copy link
Member

tsteur commented Feb 13, 2015

Should be fixed now. As mentioned in a similar issue the visitorLog html + css needs to be completely redone.

@tsteur tsteur closed this as completed Feb 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
Piwik 2.11.0
Development

No branches or pull requests
3 participants
@tsteur @mattab @hpvd