Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable "Rows to display" for evolutionLimits #5206

Open
gaumondp opened this issue May 21, 2014 · 9 comments
Open

Configurable "Rows to display" for evolutionLimits #5206

gaumondp opened this issue May 21, 2014 · 9 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.

Comments

@gaumondp
Copy link

Same as #5188 but for evolutionLimits.

Use case: Showing 1 month, 7 days (or 1 week) all seems like interesting values to have when using "Evolution over period" graphs.

Actual numbers taken from /plugins/CoreHome/javascripts/dataTable.js :


            evolutionLimits =
            {
                day: [30, 60, 90, 180, 365, 500],
                week: [4, 12, 26, 52, 104, 500],
                month: [3, 6, 12, 24, 36, 120],
                year: [3, 5, 10]
            };

Dali

@mattab
Copy link
Member

mattab commented May 25, 2014

Thanks for the feature suggestion.

@gaumondp gaumondp added this to the Future releases milestone Jul 8, 2014
@mattab mattab modified the milestones: Long term, Mid term Dec 23, 2015
@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
@fritzgithub
Copy link

I would also appreciate more flexibility or more reasonable numbers. Once again I stumbled over the uneven ratio for a monthly display:
3, 6, 12, 24, 36, 120
3x2=6
6x2=12
12x2=24
24x1,5=36
36x3,33...=120
If doubling numbers would continue, it would be fine for us:
3,6,12,24,48,96
But I guess some people need a longer max-interval to see all data.

And I do not know, why anybody would want to see only three or six months, since this is included
good enough in a 12 months report or some weekly report. Just my 5 cents.

Fritz

@fritzgithub
Copy link

Any news on this topic?
I would really appreciate more insightful numbers, eg. numbers that always double the time range.
The better alternative would be custum settings.
Kind regards
Fritz

@mattab
Copy link
Member

mattab commented Aug 6, 2020

@fritzgithub we can maybe add some new numbers to the list.

The current list is at https://github.com/matomo-org/matomo/blob/3.x-dev/plugins/CoreHome/javascripts/dataTable.js#L655-L661

What would you suggest as the new list?

@mattab mattab removed this from the Backlog (Help wanted) milestone Aug 6, 2020
@fritzgithub
Copy link

Hi, thank you for listening.

  • day: suggested new values are fine with me (day: [8, 30, 60, 90, 180])
  • week: suggested new values are fine with me (week: [4, 12, 26, 52, 104],)
  • month: current values: month: [3, 6, 12, 24, 36, 120]
    • I dont see any sense in 3 month, but that is only my personal opinion
    • I would reduce the gap after three years:
      • either add two values: 6, 12, 24, 36, 48, 60, 120
      • or doubling intervals: 6, 12, 24, 48, 96
  • year: current values: year: [3, 5, 10]
    • you know better what might the longest existing timerange of matomo/piwik data. In less than two years we need a longer timerange
    • I suggest: 5, 10, 15 (or 3, 5, 10, 15)

@dev-101
Copy link

dev-101 commented Feb 20, 2021

Any chance we get this by 2022? :)

We ask only for a simple array expansion, without resolving to yet another plugin hack or something, that could be easily set in admin dashboard to our need/liking. For example, I would like to extend days selector to 730 and 1095 values (why stop at unnatural "500"?).

Also, if we use last30 param to view e.g. pages reports, date selector dropdown is removed from view - why? Why not simply revert to default days selector in that case?

@tsteur tsteur added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Feb 21, 2021
@tsteur
Copy link
Member

tsteur commented Feb 21, 2021

@dev-101 feel free to create a pull request and we will be happy to review. It should be indeed an easy change and the hardest part be probably coming up with the numbers. For numbers > 500: This would maybe need a test re performance and how long it takes to fetch so many data points. Be indeed great to have more natural numbers in the selection.

@dev-101
Copy link

dev-101 commented Feb 21, 2021

Hi, I think PR for this is trivial and not a point. Creating a PR for this means nothing if it won't be accepted by project owners. Given the age of this issue, it is unlikely it will happen :)

@tsteur
Copy link
Member

tsteur commented Feb 21, 2021

@dev-101 I'm not seeing why we wouldn't accept the PR. The change sounds useful to me 👍 . The only thing we'd need to look at are whether values over 500 are still loading fast enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Development

No branches or pull requests

6 participants