Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run javascript unit tests on minified Javascript tracker #5195

Closed
mattab opened this issue May 20, 2014 · 4 comments
Closed

Run javascript unit tests on minified Javascript tracker #5195

mattab opened this issue May 20, 2014 · 4 comments
Labels
answered For when a question was asked and we referred to forum or answered it. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
Backlog (Help wan...

Comments

@mattab
Copy link
Member

mattab commented May 20, 2014

Our Javascript tests currently run for the non minified version of piwik.js

when changing the test file to test not the "original /js/piwik.js" but instead test the minified /piwik.js then the test fail (see attached screenshot)

The line to change is: https://github.com/piwik/piwik/blob/master/tests/javascript/index.php#L51-51

Proposed steps:

  • Investigate why the tests fail on the minified JavaScript tracker
  • Run the Javascript tracker tests on both the minified and non minified versions
@mattab
Copy link
Member Author

mattab commented May 20, 2014

Attachment: javascript tests fail on minified piwik.js
.png

@tsteur
Copy link
Member

tsteur commented May 21, 2014

It cannot work with the compiled version as lots of code is removed during the compressing such as:

/*<DEBUG>*/
...
/*</DEBUG>*/

Don't think it makes sense to run the tests with the minified version as 90% of the tests cannot work.

@mattab
Copy link
Member Author

mattab commented May 21, 2014

moving to feature request

@mattab mattab added this to the Future releases milestone Jul 8, 2014
@mattab mattab modified the milestones: Long term, Mid term Dec 23, 2015
@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
@sgiehl
Copy link
Member

sgiehl commented Nov 19, 2017

duplicates #5165

@sgiehl sgiehl closed this as completed Nov 19, 2017
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
answered For when a question was asked and we referred to forum or answered it. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
3 participants
@tsteur @mattab @sgiehl