@d-skora opened this Issue on May 15th 2014

Currently, any non-anonymous logged-in user, can add new segment.

Expected: as a Piwik admin I want to set that only users with "view" or "admin" or "superuser" permission can create new segments.

@mattab commented on May 19th 2014 Member

Thanks for the suggestion! See pull request: https://github.com/piwik/piwik/pull/275

@mattab commented on May 21st 2014 Member

In 22227f61c2a19f1d7dcb672aade78636ed114147: Merge pull request #275 from d-skora/feature/SegmentEditor

Feature/segment editor Fixes #5172

@mattab commented on May 22nd 2014 Member

I realised the ticket description was not clear, and so the code IMHO is not correct.

I will commit some fix.

@mattab commented on May 22nd 2014 Member

In bdc6dbbf90dffb919d029b83520b7258c71abbcd: Refs #5172 Make sure anonymous user cannot edit segments + rename superadmin to superuser for consistency

@mattab commented on May 22nd 2014 Member

In f1c47b85fbdc0c89995062aed41b6a83726938a9: Refs #5172 Rename siteid to idSite for consistency

@mattab commented on May 22nd 2014 Member

In a1577f21172211de66d561ea92490644756fbd0d: Refs #5172 Fix bug, use proper idSite value

@mattab commented on May 22nd 2014 Member

In 8885f29e36f2be15800f63cb42d94d1268951795: Refs #5172 Rename config setting with a clear name, adding_segment_requires_access
idSite===false is not valid use case AFAIK so removing code that deals with that.

@mattab commented on May 22nd 2014 Member

In 75871caf164d5b915b4c10bc4e2cb04ed29083fa: Fixes #5172 Should be code complete

This Issue was closed on May 22nd 2014
Powered by GitHub Issue Mirror