Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA: run Javascript tests on both the original and minified JS #5165

Open
mattab opened this issue May 14, 2014 · 1 comment
Open

QA: run Javascript tests on both the original and minified JS #5165

mattab opened this issue May 14, 2014 · 1 comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
Backlog (Help wan...

Comments

@mattab
Copy link
Member

mattab commented May 14, 2014

Use case: as a Piwik core developer, I make changes to js/piwik.js. I forget to compile/minify the Javascript as per instructions in: https://github.com/piwik/piwik/tree/master/js#introduction

Got: mismatch between js/piwik.js and piwik.js. Javascript tests still pass (because they run on js/piwik.js)

Expected: Javascript tests should have failed.

Alternative solution:

  • Unit test that runs the minifier to check that the piwik.js is the same as minified js/piwik.js
@tsteur
Copy link
Member

tsteur commented May 14, 2014

In 9c71faa: refs #5165 this is not directly related but can prevent forgetting to minify piwik.js. Whenever js/piwik.js is updated grunt will automatically minify/compile it instantly

@mattab mattab added this to the 2.x - The Great Piwik 2.x Backlog milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#5165 this is not directly related but can prevent for…
9c71faa 
…getting to minify piwik.js. Whenever js/piwik.js is updated grunt will automatically minify/compile it instantly
@mattab mattab added the c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. label Oct 10, 2014
@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
@sgiehl sgiehl mentioned this issue Nov 19, 2017
Closed
@Findus23 Findus23 mentioned this issue Jan 17, 2020
Open
@rr-it rr-it mentioned this issue Jul 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
2 participants
@tsteur @mattab