New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When AdBlock Plus is used, suggest user to disable it for Piwik #5094
Comments
👍 for this. Many will open Piwik and even demo.piwik.org and just think that it doesn't work |
one should do this detection really carefully |
I would suggest to understand why parts of piwik-backend are blocked
|
so it should be possible to completely disable this function and making EVERY SINGLE part of this code invisible on the website (for those who would not like to play with honey when there are bees outside) |
Also experienced in forums: http://forum.piwik.org/read.php?2,129115
|
There are tricks to detect adblocker is running eg. http://stackoverflow.com/a/24111206 But we want to detect whether the adblocker is currently blocking some of the Piwik JS content, as many ad blockers will correctly let Piwik dashboard render, so we shouldn't notify users in that case. |
There are 100 ways javascript or Piwik can be broken. So i would suggest a more general solution. What about saving a list of the .js files which should get loaded in the HTML main file. When something is wrong, then display the user some possible solutions: |
When development mode is disabled, we have only one or two files to load but I like that idea which I had not thought about before. Eg we could check something like We will need to embed this code into the HTML page as it might not be executed otherwise |
I checked Dashboard and Admin area with Ublock Origin extension in Chrome and Firefox, with development mode enabled and disabled but couldn't reproduce. Can anyone reproduce it and let me know if there are any configurations to be done? |
FYI: The following terms are blocked eg by easyprivacy list:
So using eg this URL results in no js file being loaded: The requests actually start but never finish, not sure how we can detect this in general. Also it always depends on the Piwik URL etc which Piwik files will be loaded and which not. Eg when using |
I worked on a detection but it's not trivial as maybe all JavaScript files are blocked and we cannot rely on anything. How it works:
Why do we not only do the Do we detect all ad blocker? How does the ad blocker block our content? How does the warning look? |
Adblock plus creates issues when used for Piwik app. AdblockPlus blocks some javascript from executing because of their filenames and/or path. It catches false positive in the Piwik user interface.
This was reported many times over, for example here.
Proposal
The text was updated successfully, but these errors were encountered: