Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Period::factory() -> use Period\Factory::build() instead #5065

Closed
mattab opened this issue May 2, 2014 · 3 comments
Closed

Deprecate Period::factory() -> use Period\Factory::build() instead #5065

mattab opened this issue May 2, 2014 · 3 comments
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.2.1

Comments

@mattab
Copy link
Member

mattab commented May 2, 2014

For clean code, we have moved Period::factory() to its own factory class at Period\Factory.

Done in: 02e030e

There is a backward compatibility function until June 15th.
@mattab
Copy link
Member Author

mattab commented May 2, 2014

In 952b8aa: refs #5065 add back the factory() method for backward compat

@mattab
Copy link
Member Author

mattab commented May 2, 2014

In ffdc6f0: refs #5065 add test to be reminded to remove @deprecated method

@tsteur
Copy link
Member

tsteur commented May 5, 2014

Can we close this one?

@mattab mattab added this to the 2.2.1 - Piwik 2.2.1 milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
refs matomo-org#5065 add back the factory() method for backward compat
952b8aa
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
refs matomo-org#5065 add test to be reminded to remove @deprecated me…
ffdc6f0 
…thod
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.2.1
Development

No branches or pull requests
2 participants
@tsteur @mattab