Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setSuperUserAccess overwrites login with any super user login #5004

Closed
mattab opened this issue Apr 16, 2014 · 2 comments
Closed

setSuperUserAccess overwrites login with any super user login #5004

mattab opened this issue Apr 16, 2014 · 2 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
2.2.0

Comments

@mattab
Copy link
Member

mattab commented Apr 16, 2014

When calling setSuperUserAccess the login is overwritten by any super user access.

we should disable this as it creates issues when other code is using the username.

https://github.com/piwik/piwik/blob/master/core/Access.php#L233-236
@mattab
Copy link
Member Author

mattab commented Apr 17, 2014

In 4b2b8f5: Refs #5004 Remove the "login" override when setting a user as super user.
Let's see if any test or screenshot test fails

@mattab
Copy link
Member Author

mattab commented Apr 17, 2014

In a75372f: Refs #5004 remove unused code

@mattab mattab added this to the 2.2.0 - Piwik 2.2.0 milestone Jul 8, 2014
@mattab mattab mentioned this issue Apr 23, 2014
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
1 participant
@mattab