Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users List messup in UsersManager settings UI regression #4912

Closed
tassoman opened this issue Mar 26, 2014 · 5 comments
Closed

Users List messup in UsersManager settings UI regression #4912

tassoman opened this issue Mar 26, 2014 · 5 comments
Assignees
@diosmosis
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
2.2.1

Comments

@tassoman
Copy link
Contributor

Ciao, I'm experiencing a problem in Users Manager UI web interface since 2.1.1-b4. As you can see in this screenshot:

  • users table is missing the last cell while adding a new user
  • pre-defined texts aren't clearing input onClick
  • users list is messed up

My server configuration is plain Ubuntu 12.04 LTS, with PHP 5.3.10, apache 2.2.2 mySql 5.5. Browser is Firefox 28
Keywords: usersmanager, users, manager, ui, admin
@tassoman
Copy link
Contributor Author

I've discovered there is a new column called "Last Seen", so I've sent a pull request about it but still needs some work on it, some help is appreciated. :)

[https://github.com//pull/254]

@tassoman
Copy link
Contributor Author

tassoman commented Apr 1, 2014

I've updated the pull request, now solution is OK to be evaluated.

@diosmosis
Copy link
Member

Hi @tassoman, thanks for the bug report and research. The pull request contains many changes that are unrelated to this bug, including file mode changes and changes to .gitignore, so it won't be merged, but the research you did definitely saved us time.

@diosmosis
Copy link
Member

In c5a8686: Fixes #4912, fix regressions in UsersManager/index.twig that resulted from last seen column addition: do not loop w/ reference when var w/ same name is used below, add extra blank cell for add new user row and remove erroneous condition in LastSeenTimeLogger. Thanks to @tassoman for research into first two issues.

@tassoman
Copy link
Contributor Author

tassoman commented Apr 1, 2014

Replying to capedfuzz:

Hi @tassoman, thanks for the bug report and research. The pull request contains many changes that are unrelated to this bug, including file mode changes and changes to .gitignore, so it won't be merged, but the research you did definitely saved us time.

Glad for being helpful :) I wasn't aware about not related modifications, how can I avoid it next time? Sorry but I'm just experiencing git development nowadays, some hint would be helpful

@tassoman tassoman added this to the 2.2.1 - Piwik 2.2.1 milestone Jul 8, 2014
@snyk-bot snyk-bot mentioned this issue Oct 16, 2022
Open
@sirinartk sirinartk mentioned this issue Oct 17, 2022
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diosmosis diosmosis

Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
2.2.1
Development

No branches or pull requests
2 participants
@tassoman @diosmosis