Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay: overwriting the API endpoint with setAPIUrl does not work in JS #4856

Closed
mattab opened this issue Mar 14, 2014 · 1 comment
Closed
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Mar 14, 2014

Reported by Michal:

I checked this setApiUrl method for js tracker and there seems to be problem with order of executing fuctions
for some reason trackPageView gets triggered before setAPIUrl and therefore overlay isn't initialized with proper URL
if I put 'trackPageView' in setTimeout statement, then it works ok but I believe it's not a proper solution to this

@mattab
Copy link
Member Author

mattab commented Mar 14, 2014

In c27698f: Fixes #4856 Make sure setAPIUrl, when called, is executed before any other request is sent.

@mattab mattab added this to the 2.2.1 - Piwik 2.2.1 milestone Jul 8, 2014
@mattab mattab self-assigned this Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

1 participant