Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

problem with some segments not being pre-processed #4827

Closed
mgazdzik opened this issue Mar 7, 2014 · 9 comments
Closed

problem with some segments not being pre-processed #4827

mgazdzik opened this issue Mar 7, 2014 · 9 comments
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. worksforme The issue cannot be reproduced and things work as intended.
Milestone
Backlog (Help wan...

Comments

@mgazdzik
Copy link
Contributor

mgazdzik commented Mar 7, 2014

Using latest stable Piwik version (2.1.0) we found following bug in segments processing in UI. It basically comes to redundant url-decoding action during display of segmented widgets. Basically it works like that:

  • browser archiving is disabled, also browser_archiving_disabled_enforce is set to 1
  • segments are pre-processed with cron archiving
  • define 2 segments (set them to process via cron in editor), for example: test1 = pageTitle!=aaaaaa, test2=pageTitle!=aaaaaa bbbbbbbb
  • track some visits (I used visitor generator)
  • run archive.php
  • visits are archived, segments are recognized and calculated
  • log into dashboard, select segment test1 (without space) - on Visits Over Time you can see that there are some visits calculated.
    Select test2(with space in content) - you'll notice that graph is empty.

Moving deeper into this specific segment with space showing no data for dashboard, showed that if you enter Visitors Overview - you actually get graph displaying proper visits.

Here are segment strings copied from export to xml link for dashboard and Visitors Overview
dashboard: pageTitle!%3Daaaaaa%2520bbbbbbbb
visitors overview: pageTitle!=aaaaaa bbbbbbbb

that brings me to conclusion that segment string from UI request isn't passed well to API request for given widget in dashboard?
Keywords: segment, cron archive
@mattab
Copy link
Member

mattab commented Mar 16, 2014

This was fixed in 4fdd05a

@mattab
Copy link
Member

mattab commented Mar 16, 2014

Wrong fix + needs tests

@mattab
Copy link
Member

mattab commented Mar 17, 2014

In de8c605: Refs #4827 Adding test case: segment is pre-processed, and test both cases: with, or without URL encoding

@mattab
Copy link
Member

mattab commented Mar 17, 2014

In a6963a9: Refs #4827 Forgot to commit test fixture changes

@mattab
Copy link
Member

mattab commented May 6, 2014

Problem is fixed. tests are still not running so leaving ticket opened

Todo:

@mgazdzik mgazdzik added this to the 2.5.0 - Piwik 2.5.0 milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4827 Adding test case: segment is pre-processed, and …
de8c605 
…test both cases: with, or without URL encoding
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4827 Forgot to commit test fixture changes
a6963a9
@mattab
Copy link
Member

mattab commented Dec 1, 2014

This should mostly work now. There are still tests to be un-commented in: https://github.com/piwik/piwik/blob/master/tests/PHPUnit/System/ArchiveCronTest.php#L32-65 I've created an issue to look into: Activate all CronArchive system tests #6753

@mattab mattab closed this as completed Dec 1, 2014
@mattab mattab added the worksforme The issue cannot be reproduced and things work as intended. label Dec 1, 2014
@iMarkus
Copy link
Contributor

iMarkus commented Nov 28, 2016

Hi,
we are currently facing such issues with Piwik 2.16.2

The widgets do not show any contents when the following segment is used:

pageUrl=@site.domain.com%2Flocation%2Fxyz%2Fen-us%2Forg%2Faaa%2Fbbb%20ccc%20ddd%20eee

but it displays data when using:

pageUrl=^site.domain.com%2Flocation%2Fwxyz%2Fen-us%2Forg%2Faaa%2Fbbb

It looks like %20 is not working correctly for segmentation. Also exact matches with blanks in the URL are not working. Example:

pageUrl==site.domain.com%2flocation%2fxyz%2fen-us%2forg%2faaa%2fbbb%20ccc%20ddd%20eee%2fpages%2ftools.aspx

we also tried to use + instead of %20 with no difference

pageUrl==site.domain.com%2flocation%2fxyz%2fen-us%2forg%2faaa%2fbbb+ccc+ddd+eee%2fpages%2ftools.aspx

@mattab
Copy link
Member

mattab commented Dec 6, 2016

Hi @iMarkus Thanks for the report! since this issue is already closed, could you please copy it in a new issue?

@iMarkus
Copy link
Contributor

iMarkus commented Dec 6, 2016

Hi mattab,

as we are piwik pro customers i opened a ticket.

Regards,
Markus

@iMarkus iMarkus mentioned this issue Dec 6, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
3 participants
@mattab @mgazdzik @iMarkus