Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition and Overlay does not work when site-url contains & #4815

Closed
mbresch-sf opened this issue Mar 5, 2014 · 4 comments
Closed

Transition and Overlay does not work when site-url contains & #4815

mbresch-sf opened this issue Mar 5, 2014 · 4 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.

Comments

@mbresch-sf
Copy link

If a site-url contains more than one GET-parameters like /index.php?param1=foo&param2=bar the transition and overlay returns "There is no data for http://domain.tld/index.php?param1=foo&param2=bar"

To reproduce this issue click in Piwik Action->Pages-><transition icon of a url with more than one GET-parameter>

I found a solution in \Piwik\Tracker\TableLogAction::getIdActionFromSegment in line 202:

#!div style="font-size: 80%"
Code highlighting:

!php

$valueToMatch = Common::sanitizeInputValue(Common::unsanitizeInputValue($valueToMatch));

This line translates the $valueToMatch from "domain.tld/index.php?param1=foo**&param2=bar" to "domain.tld/index.php?param1=foo&param2=bar". But the action_name in the database is "domain.tld/index.php?param1=foo&**param2=bar".

My solution is to comment out line 202 so I get the right url which is matching with the database value.

Find usages of this method told me, that only the transition plugin is using this function.

Maybe this bug is related to #4595
Keywords: transition overlay

@mattab
Copy link
Member

mattab commented Apr 27, 2014

Moving bugs to our current milestone to make the backlog more realistic.

@mbresch-sf mbresch-sf added this to the 2.5.0 - Piwik 2.5.0 milestone Jul 8, 2014
@mattab
Copy link
Member

mattab commented Nov 13, 2014

#4595

@mattab mattab closed this as completed Nov 13, 2014
@mattab mattab added the duplicate For issues that already existed in our issue tracker and were reported previously. label Nov 13, 2014
@mattab
Copy link
Member

mattab commented Nov 13, 2014

Fixed in latest 2.9.0 beta!

@HermannPRODYNA
Copy link

I have exactly the problem described here with Piwik version 2.14.3.

In Actions->Pages any page containing an '&' gets "There's no data for..." when trying to open transitions.
There are no problems for any pages that don't contain '&'

Update: I opened a ticket #9296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Development

No branches or pull requests

3 participants