Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom date range period of one week should use weekly archive when available #4754

Closed
mattab opened this issue Feb 25, 2014 · 1 comment
Closed

Custom date range period of one week should use weekly archive when available #4754

mattab opened this issue Feb 25, 2014 · 1 comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Performance For when we could improve the performance / speed of Matomo. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. worksforme The issue cannot be reproduced and things work as intended.
Milestone
2.1

Comments

@mattab
Copy link
Member

mattab commented Feb 25, 2014

For periods that are Date ranges (period=range) and that are:

  • exactly one week
  • exactly one month
  • exactly one year

then, if it has been pre-processed before, it should use the existing Week / month or year report.

  • index.php?module=API&method=API.get&idSite=1&period=week&date=2014-02-18&format=xml
  • index.php?module=API&method=API.get&idSite=1&period=range&date=2014-02-16,2014-02-23&format=xml

In my tests, the second request was not using the blob from the first request, as it triggered archiving (and took 20s to return).

So, we should fix the algorithm which will result in better performance and user experiece.
@mattab
Copy link
Member Author

mattab commented Feb 25, 2014

The second request was slow because it was selecting the weekly data and then copying it into the new archive. We could avoid such copy when the range is exactly an existing range, but this won't make much difference.

So, the assumption about range not using existing period was wrong. It already works...

@mattab mattab added this to the 2.1 - Piwik 2.1 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Performance For when we could improve the performance / speed of Matomo. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
1 participant
@mattab