Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce AngularJS to Piwik, first step: Website Selector rewrite #4690

Closed
mattab opened this issue Feb 17, 2014 · 2 comments
Closed

Introduce AngularJS to Piwik, first step: Website Selector rewrite #4690

mattab opened this issue Feb 17, 2014 · 2 comments
Assignees
Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Feb 17, 2014

This is the email kickstart of the new AngularJS adventure! We'll do our best to make the most out of AngularJS & work as a team to make this a positive change. Thomas will get started on Benaka's suggestion.

Goal: integrate the website selector widget as an example of how to best use AngularJS.

It should have the following requirements:

  1. the selector should be in a self-contained class/widget/whatever
  2. the selector should be re-usable; specifically it should be possible to place it in another template and place two or more in one page (the selector is used in a couple places, so there'll be ways to test this)
  3. the selector should be customizable
  4. the selector should be documented and it should be possible (at least conceptually) to expose this documentation to plugin developers
  5. ensure the selector's resources are cleaned up properly on page change, widget reload, etc.
  6. Untrusted input should be escaped but not by Piwik itself (for example w/ jquery: $('&lt;span/&gt;').text(site.name); instead of $('<span>' + site.name + '</span>');).
  7. it should be possible to create another class/widget/whatever that extends the site selector

once this is done, a set of patterns for using angular-js in Piwik should be observable.

@tsteur
Copy link
Member

tsteur commented Mar 12, 2014

In ad29373: refs #4690 added documentation

@tsteur
Copy link
Member

tsteur commented Mar 12, 2014

This is done except for part 4 exposing documentation to developer.piwik.org. This is to be defined and listed in #4691

@mattab mattab added this to the 2.2.1 - Piwik 2.2.1 milestone Jul 8, 2014
@tsteur tsteur modified the milestones: 2.4.0 - Piwik 2.4.0, 2.2.1 - Piwik 2.2.1 Jul 11, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

2 participants