@mattab opened this Issue on February 12th 2014 Member

We have made some changes in the Log Analytics script. It now requires Python 2.7 to function.

Please make sure you use at least Python 2.7 to use Log Analytics.

We need 2.7 for this particular feature: http://docs.python.org/2/library/subprocess.html#subprocess.check_output

see also #4668 where this requirement increase was initially reported.

@mattab commented on February 12th 2014 Member

I have updated the user guide "Log analytics" to document that it now requires Python 2.7.

@mattab commented on February 12th 2014 Member

In 8f035e979e99c143b82c3d78cf851d4cd6fe7229: Refs #4670 Document python requirement in the file comment header

@anonymous-piwik-user commented on February 13th 2014

Sorry for late response. I do not think that this was wise step. At least not now at this stage. Still current RHEL 6.5 and derivatives have officially support for version python-2.6.6-51.el6.x86_64. Primary target for RHEL & co. are servers where also piwik is in use. Upgrade of such important package is not always trivial. If you upgrade python to 2.7 you break "yum" system package update manager. I believe that this will raise a lot of problems...

I believe that some kind of compromise should be considered ... Rethink and replay.

Thanks in advance for your CPU cycles :-)

@mattab commented on February 15th 2014 Member

Thanks, you make some good points here!

I created this ticket hoping you would tell me why it wasn't a good idea, as I had a feeling this could create some trouble. Instead, we'll change to use a 2.6 compatible code.

@diosmosis commented on February 15th 2014 Member

In 3c6690941b56e9af732f4dcf5a95435be0c2794e: Fixes #4670, use popen in import_logs.py to run updatetokenfile.php instead of check_output.

@diosmosis commented on February 15th 2014 Member

In 48218768d826ba305049e408fb4f0b1761bbecaa: Refs #4670, remove 2.7 header requirement.

@anonymous-piwik-user commented on February 15th 2014

"2.6 compatible" code seems OK for now and that is wise decision. If there is really problem with python 2.6 functionality then is maybe wise to include part of code (available functionality) which is executed under python 2.7 only.

RHEL is slow with packages upgrade and normally they bring major package upgrade with new major versions of their linux. Like now when RHEL 7.0 is on sight and python would be upgraded to version 2.7.5. I suggest that a reminder ticket is created to check status in about 6-9 months. At about that time also sufficient RHEL 7.x and derivatives would be deployed with python 2.7.x packages. At that time would be appropriate to include python 2.7 in piwik mainstream.

It would be nice to know from other folks if some other major linux distro have also problem with migration to python 2.7 ...

Thanks for wise decision.

@mattab commented on February 16th 2014 Member

Cheers @capedfuzz for the fix and @hornbeam for the feedback and reporting this issue early after the RC release... that really helps!

This Issue was closed on February 16th 2014
Powered by GitHub Issue Mirror