Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Log Analytics now requires Python 2.7 #4670

Closed
mattab opened this issue Feb 12, 2014 · 8 comments
Closed

regression: Log Analytics now requires Python 2.7 #4670

mattab opened this issue Feb 12, 2014 · 8 comments
Assignees
Labels
Critical Indicates the severity of an issue is very critical and the issue has a very high priority. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Feb 12, 2014

We have made some changes in the Log Analytics script. It now requires Python 2.7 to function.

Please make sure you use at least Python 2.7 to use Log Analytics.

We need 2.7 for this particular feature: http://docs.python.org/2/library/subprocess.html#subprocess.check_output

see also #4668 where this requirement increase was initially reported.

@mattab
Copy link
Member Author

mattab commented Feb 12, 2014

I have updated the user guide "Log analytics" to document that it now requires Python 2.7.

@mattab
Copy link
Member Author

mattab commented Feb 12, 2014

In 8f035e9: Refs #4670 Document python requirement in the file comment header

@anonymous-matomo-user
Copy link

Sorry for late response. I do not think that this was wise step. At least not now at this stage. Still current RHEL 6.5 and derivatives have officially support for version python-2.6.6-51.el6.x86_64. Primary target for RHEL & co. are servers where also piwik is in use. Upgrade of such important package is not always trivial. If you upgrade python to 2.7 you break "yum" system package update manager. I believe that this will raise a lot of problems...

I believe that some kind of compromise should be considered ... Rethink and replay.

Thanks in advance for your CPU cycles :-)

@mattab
Copy link
Member Author

mattab commented Feb 15, 2014

Thanks, you make some good points here!

I created this ticket hoping you would tell me why it wasn't a good idea, as I had a feeling this could create some trouble. Instead, we'll change to use a 2.6 compatible code.

@diosmosis
Copy link
Member

In 3c66909: Fixes #4670, use popen in import_logs.py to run updatetokenfile.php instead of check_output.

@diosmosis
Copy link
Member

In 4821876: Refs #4670, remove 2.7 header requirement.

@anonymous-matomo-user
Copy link

"2.6 compatible" code seems OK for now and that is wise decision. If there is really problem with python 2.6 functionality then is maybe wise to include part of code (available functionality) which is executed under python 2.7 only.

RHEL is slow with packages upgrade and normally they bring major package upgrade with new major versions of their linux. Like now when RHEL 7.0 is on sight and python would be upgraded to version 2.7.5. I suggest that a reminder ticket is created to check status in about 6-9 months. At about that time also sufficient RHEL 7.x and derivatives would be deployed with python 2.7.x packages. At that time would be appropriate to include python 2.7 in piwik mainstream.

It would be nice to know from other folks if some other major linux distro have also problem with migration to python 2.7 ...

Thanks for wise decision.

@mattab
Copy link
Member Author

mattab commented Feb 16, 2014

Cheers @capedfuzz for the fix and @Hornbeam for the feedback and reporting this issue early after the RC release... that really helps!

@mattab mattab added this to the 2.1 - Piwik 2.1 milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical Indicates the severity of an issue is very critical and the issue has a very high priority. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

3 participants