Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable_merged_assets does not work for CSS #4646

Closed
timo-bes opened this issue Feb 7, 2014 · 2 comments
Closed

disable_merged_assets does not work for CSS #4646

timo-bes opened this issue Feb 7, 2014 · 2 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.
Milestone
2.1

Comments

@timo-bes
Copy link
Member

timo-bes commented Feb 7, 2014

The config option disable_merged_assets only affects JS includes.

This is obvious when comparing \Piwik\AssetManager::getJsInclusionDirective() to \Piwik\AssetManager::getCssInclusionDirective().

I'm not sure whether this was done on purpose.

  • If yes, the source documentation needs to be adjusted in various places (search the codebase for disable_merged_assets to see where it's mentioned).
  • If no, \Piwik\AssetManager::getCssInclusionDirective() should be extended in order to apply the setting,
@timo-bes
Copy link
Member Author

timo-bes commented Feb 7, 2014

Disabling merged assets for CSS is not easy because the less files need to be compiled. Can we at least discard the cached css when disable_merged_assets is set? That would cause the wanted effect that changes to styles are immediately visible.

If this is done, the setting name should maybe be changed.

@mattab
Copy link
Member

mattab commented Feb 8, 2014

I propose a different fix, that we invalidate the merged CSS only when it has changed. for this we must somehow parse the included css/less files. See: #4523

@timo-bes timo-bes added this to the 2.1 - Piwik 2.1 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
2 participants
@timo-bes @mattab