New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop IE8 support #4620
Comments
FYI, using http://selectivizr.com/ in ComparisonDashboard to get CSS3 selectors to work (in JavaScript & in stylesheets). |
Well, since version 2.1.0 IE8 is a messup just after "Logout" link. Maybe the best choice would be handling unsupported browsers with an exception. |
I haven't tested recently, but are you saying Piwik does not work well under IE8? |
Yes, is not useful, we will deliver Firefox to all users. Open source wins. |
Attachment: Piwik 2.2.3b3 as seen by IE8 |
Hi tassoman, I test Piwik with IE8 regularly and it works for me with latest beta and with 2.1.0.
|
I got it. The problem is my IE8 configuration runs intranet websites in compatibility mode. So that can't render AngularJS stuff very well.
I've removed the flag from "run intranet websites using compatibility mode" and the render was ok. The problem is I can't modify this option to all dozens users of the intranet. I've found a post on MSDN describing how to handle this by sending html tags in the head section of the page but I'm not really sure it will help. |
To try it you can edit the file: https://github.com/piwik/piwik/blob/master/plugins/Zeitgeist/templates/dashboard.twig#L10-10 and put the meta tag there. Then you should see the meta tag in the "Analytics report" in Piwik (but not on login screen or admin). Maybe it could make Piwik work well under IE8 for you? |
Looking at dashboard.twig template I've discovered you've already set the X-UA-Compatible tag and is set to IE=EDGE. By the way I've tried the hack but doesn't works. So I prefer to go with no hack. Intranet compatibility is a internal setting of IE and so can't be edited by html headers. |
Well, going deeper into the IE deal I've sorted out there's a crazy bug in IE9 that makes it ignore the UA-Compatible meta tag when conditional comments are placed before it. So that, I've hacked badly* dashboard.twig and admin.twig files removing conditional comments in html source and now IE8 it's flawlessly working also on my Piwik dev machine inside the intranet. (* I promise to git reset --hard my local branch) |
That's a good point. Once we remove support for IE8 we can remove the conditional comments as well and you won't have to patch it anymore ;) |
Good, thanks. Just keep in mind this bug is also affecting IE9 also |
Replying to tassoman:
@tassoman I've created a ticket here: #5282 Include Meta tag IE=edge for best security practises Maybe you have some comment about it? It was sent to us by email to our security email |
@tassoman maybe this stackoverflow thread is related: http://stackoverflow.com/questions/6156639/x-ua-compatible-is-set-to-ie-edge-but-it-still-doesnt-stop-compatibility-mode |
Replying to matt:
Yes Matt, it's the same stuff I mentioned in comment nr.13, as you can see in the second StackOverflow most valued reply they suggest to go straight with doctype and html declaration without any conditional comment before the html and meta tag. The first reply is about ISS7/9 but we haven't that environment so can't be helpful. |
What is the current state on supporting IE8? In ticket August 2014 is mentioned. We have October 2014 soon. Can we drop support for IE8? Would like to work on #6283 To make it work on IE8 and lower we would have to somehow call |
Hard to take the decision here as it would simply shut down Piwik for some corporations. Though we must do it at one point. What is status at AngularJS project support of IE8? as long as AngularJS works well on IE8 I reckon we should try to support it... unless it becomes really too time consuming... |
Well, as Piwik user I can say for my organization, in my SSO custom plugin I'm checking that user-agent isn't MSIE by regular expression, then forcing them logging in using a different browser throwing an handled exception while at login. Maybe this would be a community question you could solve using a poll. Can't say if integrating a 3rd parties poll plugin in core would be a good idea for tasting users opinion about a subject. Imagine something of a small tip popping up to superadmins, just like the "New piwik update is available" thing bringing a link to the survey in a new browser tab... |
Not sure about this poll. I reckon the result would be something like IE8 users voting to still support and non IE8 users will probably not really care whether we still support it or not. A problem is that we do not know how many of our users are still using IE8. We can delay #6283 but should definitely start working on it once we also start to work on using angular routes and when using it for visualizations. AngularJS 1.2.* should still support IE8. AngularJS 1.3 will drop support for IE8 and should be released soon I reckon. At least there is already an 1.3-RC3 |
I'm closing this one, but not be afraid Piwik 2.X which will be supported for more than a year from now on will be compatible with IE8. Closing this issue as support will be dropped in 3.0 |
Actually I will reopen as there's more to do:
|
fixed via #8591. As mentioned we still support IE8 for a pretty long time but in Piwik 3.0 it will be removed. |
At some point we should drop IE8 support.
As of January 2014 there are only ~10% of all users using IE8. On Piwik.org, we are seeing 1.3% using IE8.
Reasons:
Note:
I think we should support IE8 at least until August 2014 to give companies a few months to react after MS drops XP support.
The text was updated successfully, but these errors were encountered: