New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove comments still referencing old Piwik_ (before using PHP 5.3 namespaces) #4609
Labels
Task
Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
Comments
It's worth reading up on http://www.phpdoc.org/docs/latest/for-users/phpdoc/tags/package.html Both @category and @subpackage are deprecated. @Package should only be used if it does not match the namespace. Also @Package must not appear more than once in a file. I suggest the following:
Feedback? |
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
* @subpackage is deprecated * @Package must only occur once * @Package supports nesting (and can match the namespace) refs matomo-org#4609
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I did a global search in the codebase and found hundreds of cases of Piwik_XYZ written in the codebase, mostly in comments, such as Piwik_Auth, Piwik_Db, Piwik_API, etc.
We should remove these references and replace with correct phpdoc blocks (or simply remove).
This would conclude our effort of migrating the whole codebase from pre-namespace to full namespace support (see also: #4074 )
The text was updated successfully, but these errors were encountered: