Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tasks timetable plugin: take year into account #4540

Closed
hpvd opened this issue Jan 17, 2014 · 6 comments
Closed

tasks timetable plugin: take year into account #4540

hpvd opened this issue Jan 17, 2014 · 6 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@hpvd
Copy link

hpvd commented Jan 17, 2014

Take year into account by calculation of time to task...

Otherwise these things could happen:

  • tasks from last year were shown
  • time calculation results are wrong

please see attachment

screenshot was taken on January 17th, 2014

@hpvd
Copy link
Author

hpvd commented Jan 17, 2014

Attachment:
2014-01-17_20h04_51.png

@tsteur
Copy link
Member

tsteur commented Jan 24, 2014

In 8945245: refs #4540 fix time ago is not correct calculated if numberOfSeconds is negative

@tsteur
Copy link
Member

tsteur commented Jan 24, 2014

Time calculation is fixed.

I think it is intended to show previous tasks as it basically means they were not executed since then (but maybe should) and it helps you to discover this. Maybe I am wrong @matt? Please reopen if we should not show tasks from past

@hpvd
Copy link
Author

hpvd commented Jan 24, 2014

just updated to TasksTimetable v0.1.2 but it seems to be not completely fixed:

example (please see also attachment):

Scheduled Tasks
The following tasks are scheduled to be executed based on the current server time Friday 24 January 2014 09:04:13.

GeoIPAutoUpdater.update Wednesday 18 December 2013 00:00:46

(in 327 days -8746 hours)

=> time is still calculated wrong
=> maybe one should ad another text and position for "in" in front if the last run was in the past: e.g.: "ago" at the end

example:
(IN XXX days -YYYYY hours)
=>
(XXX days -yyyyyy hours AGO)

@hpvd
Copy link
Author

hpvd commented Jan 24, 2014

Attachment:
2014-01-24_10h04_47.png

@tsteur
Copy link
Member

tsteur commented Jan 26, 2014

It is fixed in Piwik core, not in the plugin itself. Meaning you will see the fix with the next Piwik release.

@hpvd hpvd added this to the 2.1 - Piwik 2.1 milestone Jul 8, 2014
@tsteur tsteur modified the milestones: 2.4.0 - Piwik 2.4.0, 2.1 - Piwik 2.1 Jul 11, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants