Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI bugs connected to subdatatables #4536

Closed
timo-bes opened this issue Jan 17, 2014 · 20 comments
Closed

UI bugs connected to subdatatables #4536

timo-bes opened this issue Jan 17, 2014 · 20 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
2.1

Comments

@timo-bes
Copy link
Member

Here's how to reproduce some bugs (tested in Safari and Chrome).

Go to http://demo.piwik.org/index.php?module=CoreHome&action=index&idSite=1&period=week&date=2014-01-10#module=Referrers&action=getSearchEnginesAndKeywords&idSite=1&period=week&date=2014-01-10

Bug 1:

  • In Search Engines, click Google - looks OK
  • Now, click Yahoo. The background of the subtable is grey - it should be white. On hover, the background is yellow - this color should not be used anymore.

(Now, refresh)

Bug 2:

  • Open Google in Search Engines
  • Hover the number of visits of Bing - the percentages are shown correctly
  • Now, hover the label of Bing - the percentages in the Google subtable are shown

(Now, refresh)

Bug 3:

  • Open any Search Engine
  • Hover any row below it. The background is too dark and as a consequence, the background of the row evolution icon is visible. This does not happen for the rows above the opened one.
@mattab
Copy link
Member

mattab commented Jan 20, 2014

Thanks for the report!

@timo-bes
Copy link
Member Author

timo-bes commented Feb 7, 2014

In 88aaf3f: refs #4536 improved striping for action data tables: when subtables are opened or closed, reset the odd/even labels. otherwise, two subsequent odd or even rows are possible.

@timo-bes
Copy link
Member Author

timo-bes commented Feb 7, 2014

In 73a1b46: refs #4536: morpheus uses odd/even css classes instead of nth-child. this way, striping works properly on nested data tables (e.g. the search engines report). also, make the css overrides more effective (e.g. add :hover).

@timo-bes
Copy link
Member Author

timo-bes commented Feb 7, 2014

In 5ad9080: refs #4536 fixing indentation of previous commits

@timo-bes
Copy link
Member Author

timo-bes commented Feb 7, 2014

Bugs 1 and 3 from the ticket description should be gone now. Please let me know when the demo is updated so that I can test the exact steps mentioned in the description.

@timo-bes
Copy link
Member Author

timo-bes commented Feb 7, 2014

In baeda26: refs #4536: only show the ratio in the current table - not in a subtable. fixes bug 2 from the ticket description.

@timo-bes
Copy link
Member Author

timo-bes commented Feb 7, 2014

I think this ticket should be done now. As I said, I'd like to test it on the demo before closing it.

Please guys, test as much as you can. It is really hard to get this right. Open and close subtables (both tables like the pages report and tables like the search engines report) randomly and see whether you can spot another error.

@mattab
Copy link
Member

mattab commented Feb 8, 2014

Nice changes!

Timo we now have the demo running latest git master at http://demo2.piwik.org
you can login there with the same username pwd as on demo.

@timo-bes
Copy link
Member Author

timo-bes commented Feb 9, 2014

demo2 doesn't have the same data so I can't test the exact steps described above. I could reproduce the issues with data from my local environment and the problems are gone there. So I guess the bugs mentioned above are fixed now.

I'd still like to try it on the regular demo but that's not urgent. When do you think it will be updated the next time?

@mattab
Copy link
Member

mattab commented Feb 9, 2014

In next couple days will be updated with the RC we are preparing.

Btw I noticed a regression:

  • in the admin table, such as Users, Websites, or Users permissions, the rows are now displayed in Grey rather than white background.

@timo-bes
Copy link
Member Author

In 6148bb1: refs #4536 admin tables are white in morpheus

@timo-bes
Copy link
Member Author

Is .entityTable the right selector to use? Please review the CSS change and test again.

@timo-bes
Copy link
Member Author

I can confirm that all three bugs from the description are now gone on the demo.

@timo-bes
Copy link
Member Author

In db95706: refs #4536: highlighting active plugins in the settings

@timo-bes
Copy link
Member Author

A commit above broke the screenshot UI tests.

I have also asked this on [[https://github.com/piwik/piwik/commit/6148bb1532fb88da4d21e8a4c1f2903a715e4c5e#commitcomment-5330187|github]]: Who determines what is expected and how can the expected screenshots be changed?

documentation] doesn't help much. Is there more documentation on the subject?

@mattab
Copy link
Member

mattab commented Feb 10, 2014

In 7df0035: Explains how to fix UI tests build refs #4536

@timo-bes
Copy link
Member Author

In 011ed63: refs #4536 Updating expected UI screenshots in submodule

@timo-bes
Copy link
Member Author

I have updated these screenshots: [[https://raw.github.com/piwik/piwik-ui-tests/master/expected-ui-screenshots/UIIntegrationTest_customalerts_list_triggered.png|alerts history], [[https://raw.github.com/piwik/piwik-ui-tests/master/expected-ui-screenshots/UIIntegrationTest_customalerts_list.png|alerts]].

The [[http://builds-artifacts.piwik.org/ui-tests.master/1622.1/screenshot-diffs/diffviewer.html|diff]] contains more but they are not related to this ticket. I guess the UI tests will still fail.

Regarding the new [[https://github.com/piwik/piwik/blob/master/tests/README.screenshots.md#using-screenshots-tests|documentation]]: Thanks for adding this. The second bullet point (Click on the latest failed build) confused me a little. What is the latest failed build? I clicked on the "build failing" icon in the readme. Is that correct? Maybe the documentation could be clearer.

@timo-bes
Copy link
Member Author

I'll go ahead and close the ticket.

As I said, the UI was changed slightly. If there are objections to the changes (see screenshots above), reopen the ticket.

@mattab
Copy link
Member

mattab commented Feb 15, 2014

In 41d2e8f: Refs #4536 Active Plugins in white, inactive plugin in grey.
Great work Timo on the other changes, it looks clean & smooth... beautiful!

@timo-bes timo-bes added this to the 2.1 - Piwik 2.1 milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@timo-bes
refs matomo-org#4536 improved striping for action data tables: when s…
88aaf3f 
…ubtables are opened or closed, reset the odd/even labels. otherwise, two subsequent odd or even rows are possible.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@timo-bes
refs matomo-org#4536: morpheus uses odd/even css classes instead of n…
73a1b46 
…th-child. this way, striping works properly on nested data tables (e.g. the search engines report). also, make the css overrides more effective (e.g. add :hover).
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@timo-bes
refs matomo-org#4536 fixing indentation of previous commits
5ad9080
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@timo-bes
refs matomo-org#4536: only show the ratio in the current table - not …
baeda26 
…in a subtable. fixes bug 2 from the ticket description.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@timo-bes
refs matomo-org#4536 admin tables are white in morpheus
6148bb1
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@timo-bes
refs matomo-org#4536: highlighting active plugins in the settings
db95706
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Explains how to fix UI tests build refs matomo-org#4536
7df0035
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@timo-bes
refs matomo-org#4536 Updating expected UI screenshots in submodule
011ed63
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4536 Active Plugins in white, inactive plugin in grey.
41d2e8f 
Great work Timo on the other changes, it looks clean & smooth... beautiful!
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
2 participants
@timo-bes @mattab