Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run all automated tests with HipHop Virtual Machine - make build green #4415

Closed
hpvd opened this issue Dec 20, 2013 · 8 comments
Closed

Run all automated tests with HipHop Virtual Machine - make build green #4415

hpvd opened this issue Dec 20, 2013 · 8 comments
Labels
c: Performance For when we could improve the performance / speed of Matomo. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Milestone
Long term

Comments

@hpvd
Copy link

hpvd commented Dec 20, 2013

The goal of this ticket is to try to make all our unit + plugins + integration tests pass when Piwik runs HHVM virtual machine. This would lead to CPU performance improvements as well as potentially some improvements in memory usage.

Follows up #4706, #4604

What is HHMV?

HHVM is a new open-source virtual machine designed for executing programs written in PHP. HHVM uses a just-in-time compilation approach to achieve superior performance while maintaining the flexibility and ease of use that PHP developers are accustomed to (dynamic features like eval(), rapid run-edit-debug cycle, etc).

HHVM is used by Facebook to serve billions of web requests per day. To date, HHVM (and its predecessor HPHPc before it) has realized over a 9x increase in web request throughput and over a 5x reduction in memory consumption for Facebook compared with the Zend PHP 5.2 engine + APC.
@mattab
Copy link
Member

mattab commented Mar 7, 2014

Original ticket as reported by @hpvd:

Maybe it's worth having al look on HHVM
"HipHop Virtual Machine for PHP"
and test Piwik using it.

For other projects there seem to be some really great speed improvements/lowering of server load using it.

At this time it's getting more and more compatible to several php base projects...

Speed:
http://www.hhvm.com/blog/1817/fastercgi-with-hhvm

compatibility:
http://www.hhvm.com/blog/2813/we-are-the-98-5-and-the-16

good decription in german:
http://www.golem.de/news/hhvm-facebooks-jit-compiler-fuer-php-ist-schneller-und-kompatibler-1312-103511.html

@mattab
Copy link
Member

mattab commented Mar 7, 2014

In 6c66d03: Refs #4415 Enable HHVM build on Travis, I expect some tests will fail so let's allow failures. Exciting...

@mattab
Copy link
Member

mattab commented Mar 11, 2014

Increasing priority of tickets in alignment with our vision of a powerful open platform

@mattab
Copy link
Member

mattab commented Mar 16, 2014

There was a bug reported in #4706 Trying to add two strings values in DataTable\Row::sumRowArray - Piwk with HHVM

@mattab
Copy link
Member

mattab commented Jun 16, 2014

In 0cf26d7: Merge pull request #317 from soukiii/master

MySQL port should be always integer (HHVM compatibility) refs #4415

Thanks for the pull request!

@hpvd hpvd added this to the 2.x - The Great Piwik 2.x Backlog milestone Jul 8, 2014
This was referenced Mar 16, 2014
Closed
Closed
@mattab mattab removed the P: normal label Aug 3, 2014
@mattab mattab changed the title Test if Piwik runs with HipHop Virtual Machine Run Piwik with HipHop Virtual Machine - make all tests green on CI Sep 17, 2014
@mattab mattab mentioned this issue Sep 17, 2014
Closed
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4415 Enable HHVM build on Travis, I expect some tests…
6c66d03 
… will fail so let's allow failures. Exciting...
@mattab mattab added the c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. label Oct 10, 2014
@mattab mattab mentioned this issue Dec 1, 2014
Closed
@asafyish
Copy link

I think this bug can be closed. I am using Piwik + nginx + HHVM for the last month with 4 websites and around 250k requests per day. Everything works correctly and cpu usage is 5% tops.

@mnapoli
Copy link
Contributor

mnapoli commented Dec 25, 2014

@asafyish this issue is about running the tests against HHVM (and having them pass).

This was referenced Jun 16, 2015
Closed
Merged
@mattab mattab changed the title Run Piwik with HipHop Virtual Machine - make all tests green on CI Run all automated tests with HipHop Virtual Machine - make build green Oct 1, 2015
@mattab
Copy link
Member

mattab commented Oct 4, 2016

We likely won't run the automated tests suite on HHVM as our build times and number of build jobs is very precious (since we often need to wait for those builds etc.). We can reopen if it changes in the future

@mattab mattab closed this as completed Oct 4, 2016
@mattab mattab added the wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it. label Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Performance For when we could improve the performance / speed of Matomo. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
Long term
Development

No branches or pull requests
4 participants
@mattab @mnapoli @asafyish @hpvd