Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In 2.0-b8 piwik.js is not minified #4328

Closed
anonymous-matomo-user opened this issue Nov 21, 2013 · 3 comments
Closed

In 2.0-b8 piwik.js is not minified #4328

anonymous-matomo-user opened this issue Nov 21, 2013 · 3 comments
Assignees
@mattab
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
2.0

Comments

@anonymous-matomo-user
Copy link

In 2.0-b8 piwik.js in the root directory is not minified.
@mattab
Copy link
Member

mattab commented Nov 21, 2013

I checked and it was minified for me? in js/ folder however it appears readable.

@anonymous-matomo-user
Copy link
Author

Could you please re-open this bug? The last change of js/piwik.js was:

$ git log -1 js/piwik.js
commit 06ac8c09501de7a1f1259cd7623dbe9ec5996c49
Author: Thomas Steur <thomas.steur@...>
Date:   Mon Nov 25 20:55:24 2013 +0000

    refs #4225 sort object to make sure we get the same test results on PhantomJS, Webkit and any other browser

Which is part of v2.0.3. However, the minified version was last commited about a month earlier, and does not contain the change above:

$ git log -1 piwik.js
commit fe4ee5dd88542796c29dd0a246eeb301f5488b3d
Author: mattab <matthieu.aubry@...>
Date:   Mon Oct 28 18:22:19 2013 +1300

    Fixes #4248 this should help with making segments visitCount and daysSinceLastVisit more accurate!

Please notice that after having minified (as described in js/README.md) and deployed the piwik.js version from 06ac8c0, tracking stopped working for me.

@mattab
Copy link
Member

mattab commented Jan 21, 2014

In 4972d10: Fixes #4328 Add latest version of minified JS file

@anonymous-matomo-user anonymous-matomo-user added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Fixes matomo-org#4328 Add latest version of minified JS file
4972d10
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattab mattab

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@mattab @anonymous-matomo-user