Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure Piwik works on IE8+ #4300

Closed
mattab opened this issue Nov 13, 2013 · 7 comments
Closed

Make sure Piwik works on IE8+ #4300

mattab opened this issue Nov 13, 2013 · 7 comments
Assignees
@tsteur
Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.0

Comments

@mattab
Copy link
Member

mattab commented Nov 13, 2013

Let's test Piwik on Internet Explorer 8 and make sure all still works: annotations, graphs, menus, admin, adding site, user, etc.

See forum post: http://forum.piwik.org/read.php?2,106854,page=1#msg-107532

  • Sparklines have black background
  • Visitor profile does not show
  • Settings - Users: Websites selector is not placed correct
@mattab
Copy link
Member Author

mattab commented Nov 13, 2013

In 0d1b8d9: Refs #4300 Adding Array.reduce fallback for IE8. Array.reduce is used in jqplot.

@MaxWinterstein
Copy link

black background error is real. all website dashboard has black background. url-encoded request looks like:

index.php?module=MultiSites&action=getEvolutionGraph&period=month&date=2011-06-01,2013-11-30&evolutionBy=visits&columns=nb_visits&idSite=19&idsite=19&viewDataTable=sparkline&colors={"backgroundColor":"#aNaNaN","lineColor":"#162c4a","minPointColor":"#ff7f7f","maxPointColor":"#75bf7c","lastPointColor":"#55aaff"}

take a look at: "backgroundColor":"#aNaNaN"

not so in reverse engineering, but this looks like the problem. when i put #ffffff in everything is fine. cant find aNaNaN anywhere in source code, so it seems like a error-return-value from a function that looks for the background?

@tsteur
Copy link
Member

tsteur commented Nov 21, 2013

In 111ac55: refs #4300 fixes the list of visited urls is not aligned on the right on ie8

@tsteur
Copy link
Member

tsteur commented Nov 21, 2013

In 163e659: refs #4300 fixes sparklines have black background in ie8

@tsteur
Copy link
Member

tsteur commented Nov 21, 2013

In c110f76: refs #4300 fix position of websites selector in users settings

@tsteur
Copy link
Member

tsteur commented Nov 22, 2013

Please reopen if someone finds more issues.

@mattab
Copy link
Member Author

mattab commented Nov 22, 2013

good stuff Thomas, users stuck on IE8 will appreciate!

@mattab mattab added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4300 Adding Array.reduce fallback for IE8. Array.redu…
0d1b8d9 
…ce is used in jqplot.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4300 fixes the list of visited urls is not aligned on…
111ac55 
… the right on ie8
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4300 fixes sparklines have black background in ie8
163e659
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4300 fix position of websites selector in users settings
c110f76
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
3 participants
@tsteur @mattab @MaxWinterstein