Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TCPDF to latest version #4288

Closed
mattab opened this issue Nov 11, 2013 · 3 comments
Closed

Update TCPDF to latest version #4288

mattab opened this issue Nov 11, 2013 · 3 comments
Assignees
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Nov 11, 2013

User reported bug in: http://forum.piwik.org/read.php?8,107402

Notice: Undefined variable: filehash in /var/www/vhosts/foxwebcreations.net/subdomains/tracking/httpdocs/libs/tcpdf/tcpdf.php on line 7421

I verified and it looks like the bug has been fixed in latest TCPDF. So let's upgrade the lib to latest.

PS: I noticed it's using composer so we could plug it our composer file...

@mattab
Copy link
Member Author

mattab commented Nov 11, 2013

In b42e9f8: Refs #4288 Upgrading TCPDF but the tests then fail. It seems the generated PDF has some random content (after copying from Processed/ -> expected/ the test still fails)

@mattab
Copy link
Member Author

mattab commented Nov 11, 2013

In 420d454: Fixes #4288 Remove from the PDF the metadata that changes with datetime, or that is random.This ensures that when we compare two binary PDF files together, the comparison does not take into account these random bits in the pdf files.

@mattab
Copy link
Member Author

mattab commented Nov 11, 2013

In 750e544: Refs #4288 removes useless files

@mattab mattab added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
@mattab mattab self-assigned this Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…s the generated PDF has some random content (after copying from Processed/ -> expected/ the test still fails)
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…ith datetime, or that is random.This ensures that when we compare two binary PDF files together, the comparison does not take into account these random bits in the pdf files.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

1 participant