Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marketplace - Check translation files when importing a new plugin version #4245

Closed
tsteur opened this issue Oct 27, 2013 · 1 comment
Closed

Marketplace - Check translation files when importing a new plugin version #4245

tsteur opened this issue Oct 27, 2013 · 1 comment
Labels
c: Marketplace For issues that affect the Matomo Plugin Marketplace where you can download plugins. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Milestone
Long term

Comments

@tsteur
Copy link
Member

tsteur commented Oct 27, 2013

In case a plugin translation file contains a not valid formatted JSON we trigger an exception in Piwik meaning Piwik is not really usable in case a plugin contains invalid JSON.

When importing a new plugin version we should check all translation files for json errors and if an error is found, abort the import and notify plugin developer about the issue.
@tsteur tsteur added this to the 2.x - The Great Piwik 2.x Backlog milestone Jul 8, 2014
@mattab mattab removed the P: normal label Aug 3, 2014
@mattab
Copy link
Member

mattab commented Aug 16, 2016

Users will have noticed this in their local Piwik when working on the plugin so shouldn't be needed I think

@mattab mattab closed this as completed Aug 16, 2016
@mattab mattab added the wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it. label Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Marketplace For issues that affect the Matomo Plugin Marketplace where you can download plugins. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
Long term
Development

No branches or pull requests
2 participants
@tsteur @mattab