@mattab opened this Issue on October 22nd 2013 Member

We do support MYSQLI but none of the team members actually use it. It may be broken and we wouldn't know it... However a lot of Piwik users are definitely using it in production...

The goal is to make our release process more agile and enjoy a more stable piwik for all.

Tasks:

  • Run tests suites (Core, Unit, Integration) on MYSQLI
    • on PHP 5.5 (we do not need to run it on all PHP versions as this may be too slow)
    • could we simply add mysqli to the current travis matrix build?
  • Investigate any bug that will be found once tests are running on MYSQLI on travis

Note:

  • it is out of scope to run the UI/screenshot tests on mysqli
@tsteur commented on November 13th 2013 Member

In 3ad167a122cd7713e74a6b4055186a151c81db56: refs #4233 for each env set testsuite and mysql_adapter

@tsteur commented on November 13th 2013 Member

In 130be309291d6c4984f832ec59b4886c8d446cf4: refs #4233 moving tests that require a database to integration as those are integration tests per se

@tsteur commented on November 13th 2013 Member

In b2f09361f2e689f4ce6815c849f1e5c24a884639: refs #4233 setting group on class level to make sure all tests within this class have this group

@tsteur commented on November 13th 2013 Member

In 1839649a5b1918f6952000bf6e7f5544b6ce24dc: refs #4233 fix class name

@tsteur commented on November 13th 2013 Member

In 5c8ba403a8fd8e097b1849d4a12b9a3c4bdde58f: refs #4233 fix log tests

@tsteur commented on November 13th 2013 Member

I ran tests locally with PHPUnit and configured travis to run Integration tests (which make use of DB) to use MYSQLI beside PDO

@mattab commented on November 13th 2013 Member
  • The whole build depends on the "sed" command to work OK. TO be sure we always run the build correctly, can you add following test:

    read $MYSQL_ADAPTER
    if PDO, test the current adapter is PDO
    if mysqli, test the current adapter is Mysqli
    else: test should fail

This way we make sure the travis really runs the right adapter and we will remember to change the build setting if we change the setting name or adapter name etc.

@tsteur commented on November 13th 2013 Member

In b89bed150ee02036e0b8a3b9d4ac12f743057d93: refs #4233 make sure value is either pdo or mysqli

@tsteur commented on November 13th 2013 Member

In 3755bfadd865a08c01c49f23ea0720ef81543d77: refs #4233 check if it creates the correct instance

This Issue was closed on November 14th 2013
Powered by GitHub Issue Mirror