Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0b1: visitor log very wide table regression #4221

Closed
hpvd opened this issue Oct 16, 2013 · 32 comments
Closed

2.0b1: visitor log very wide table regression #4221

hpvd opened this issue Oct 16, 2013 · 32 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@hpvd
Copy link

hpvd commented Oct 16, 2013

In 2.0b1: somthing went wrong visitor log is only a very wide table
was alreaday this way in 2.0a14

please see attachment.

@hpvd
Copy link
Author

hpvd commented Oct 16, 2013

Attachment:
Visitor-Log.png

@mattab
Copy link
Member

mattab commented Oct 17, 2013

I cannot reproduce this issue. Can you delete all files in piwik/tmp/* and try again?

do you see any other similar problem or only the visitor log?

@hpvd
Copy link
Author

hpvd commented Oct 18, 2013

deleted everything in piwik/tmp/
logged out and in

=> problem remains :-(

its only in visitor log, no matter which time period is chosen

@hpvd
Copy link
Author

hpvd commented Oct 18, 2013

one additional comment:
If I press the button on the bottom of the page
(please see the attached imaged)
I got the good looking detail view.
Reloading the page it looks the same again...

@hpvd
Copy link
Author

hpvd commented Oct 18, 2013

Attachment:
button.png

@hpvd
Copy link
Author

hpvd commented Oct 18, 2013

problem appears in all tested browsers: ff, ie, opera

@mattab
Copy link
Member

mattab commented Oct 23, 2013

This should be fixed in master!

@hpvd
Copy link
Author

hpvd commented Oct 25, 2013

hmm in beta 2 it looks different but not perfect...

"Visuzalization type PiwikPluginsLiveVisitorLog not found"

please see attachement.

@hpvd
Copy link
Author

hpvd commented Oct 25, 2013

Attachment:
visitor-log-piwik2b2.png

@tsteur
Copy link
Member

tsteur commented Oct 27, 2013

Hi hpvd,

which OS and PHP version are you using?

@hpvd
Copy link
Author

hpvd commented Oct 28, 2013

thanks for your question.
I'm using php 5.3.3 on linux.

@hpvd
Copy link
Author

hpvd commented Oct 29, 2013

just tested the latest version from github master (pre 2.0b3):
looks the same like in the beginning of this ticket...
Please see attachment

@hpvd
Copy link
Author

hpvd commented Oct 29, 2013

Attachment:
2013-10-29_19h42_38.png

@tsteur
Copy link
Member

tsteur commented Oct 31, 2013

In b3b3193: refs #4221 removed some not needed use statements

@tsteur
Copy link
Member

tsteur commented Oct 31, 2013

In 8adffe2: refs #4221 always include VisitorLog file, maybe there is an autoloader issue

@tsteur
Copy link
Member

tsteur commented Oct 31, 2013

I made some more changes, can you try again using the latest version from github master?

If it still does not work, can you think of any changes you made to Piwik or php.ini? Did you disable any plugins or so? Just asking because I can still not reproduce the issue with PHP 5.3.10-1ubuntu3.7.

Can you otherwise maybe try to install another fresh Piwik and check if it still happens? And/or update your PHP version to see if it fixes the issue?

Cheers and thank you very much for helping. I'd love to fix this issue for you

@hpvd
Copy link
Author

hpvd commented Oct 31, 2013

@tsteur

many thanks for your work!

Just installed the latest version from master:
now it looks different: the table only shows "-"
please see the screenshot

clicking on the marked button at the button

I now got this error message:

Notice: Use of undefined constant DEBUG_BACKTRACE_IGNORE_ARGS - assumed 'DEBUG_BACKTRACE_IGNORE_ARGS' in /html/piwik/core/Log.php on line 458
There is an error. Please report the message (Piwik 2.0-b3) and full backtrace in the Piwik forums (please do a Search first as it might have been reported already!).

Notice: Use of undefined constant DEBUG_BACKTRACE_IGNORE_ARGS - assumed 'DEBUG_BACKTRACE_IGNORE_ARGS' in /html/piwik/core/Log.php on line 458

Backtrace -->

#0 Piwik\Error::errorHandler(...) called at [/html/piwik/core/Log.php:458]
#1 Piwik\Log->doLog(...) called at [/html/piwik/core/Log.php:486]
#2 Piwik\Log::log(...) called at [/html/piwik/core/Log.php:179]
#3 Piwik\Log::warning(...) called at [/html/piwik/core/Plugin/Visualization.php:74]
#4 Piwik\Plugin\Visualization->buildView(...) called at [/html/piwik/core/Plugin/ViewDataTable.php:254]
#5 Piwik\Plugin\ViewDataTable->render(...) called at [/html/piwik/core/ViewDataTable/Factory.php:123]
#6 Piwik\ViewDataTable\Factory::renderReport(...) called at [/html/piwik/plugins/Live/Controller.php:99]
#7 Piwik\Plugins\Live\Controller->getLastVisitsDetails(...) called at [:]
#8 call_user_func_array(...) called at [/html/piwik/core/FrontController.php:114]
#9 Piwik\FrontController->dispatch(...) called at [/html/piwik/index.php:56]

WARN Live06:36:38 [67225] Failed to get data from API: Trying to add two strings values in DataTable\Row::sumRowArray: '�9 ' + '�9 '

maybe it helps also for the other error..

As far as i can remember there are no changes in php ini.
I'll try updating php and/or a fresh install during the day

@hpvd
Copy link
Author

hpvd commented Oct 31, 2013

Attachment:
2013-10-31_07h33_14.png

@hpvd
Copy link
Author

hpvd commented Oct 31, 2013

Attachment:
2013-10-31_07h37_05.png

@hpvd
Copy link
Author

hpvd commented Oct 31, 2013

php is now updated to 5.3.27:
the table looks much better now :-)

only 4 columns, well structured and the icons show up in the right way etc

but there are some yellow error boxes in the 4th column:


here is an error. Please report the message (Piwik 2.0-b3) and full backtrace in the Piwik forums (please do a Search first as it might have been reported already!).

Warning: htmlspecialchars() [function.htmlspecialchars]: Invalid multibyte sequence in argument in /html/piwik/vendor/twig/twig/lib/Twig/Extension/Core.php on line 927

Backtrace -->

#0 Piwik\Error::errorHandler(...) called at [:]
#1 htmlspecialchars(...) called at [/html/piwik/vendor/twig/twig/lib/Twig/Extension/Core.php:927]
#2 twig_escape_filter(...) called at [/html/piwik/tmp/templates_c/57/26/f50133f3038ccbfc28e1ecc8d3b1b89982619950037a3321ccfb9c3ede32.php:268]
#3 __TwigTemplate_5726f50133f3038ccbfc28e1ecc8d3b1b89982619950037a3321ccfb9c3ede32->doDisplay(...) called at [/html/piwik/vendor/twig/twig/lib/Twig/Template.php:264]
#4 Twig_Template->displayWithErrorHandling(...) called at [/html/piwik/vendor/twig/twig/lib/Twig/Template.php:238]
#5 Twig_Template->display(...) called at [/html/piwik/tmp/templates_c/b4/a1/a35ef731cdf931ecd4994401b308abd53b13fd3c1ed013a537523891a337.php:584]
#6 __TwigTemplate_b4a1a35ef731cdf931ecd4994401b308abd53b13fd3c1ed013a537523891a337->doDisplay(...) called at [/html/piwik/vendor/twig/twig/lib/Twig/Template.php:264]
#7 Twig_Template->displayWithErrorHandling(...) called at [/html/piwik/vendor/twig/twig/lib/Twig/Template.php:238]
#8 Twig_Template->display(...) called at [/html/piwik/tmp/templates_c/f6/f4/6ed24a7d9ed3e245fa01550d6ed4e014f32f8bce916134512d56978f453c.php:117]
#9 __TwigTemplate_f6f46ed24a7d9ed3e245fa01550d6ed4e014f32f8bce916134512d56978f453c->doDisplay(...) called at [/html/piwik/vendor/twig/twig/lib/Twig/Template.php:264]
#10 Twig_Template->displayWithErrorHandling(...) called at [/html/piwik/vendor/twig/twig/lib/Twig/Template.php:238]
#11 Twig_Template->display(...) called at [/html/piwik/vendor/twig/twig/lib/Twig/Template.php:249]
#12 Twig_Template->render(...) called at [/html/piwik/vendor/twig/twig/lib/Twig/Environment.php:300]
#13 Twig_Environment->render(...) called at [/html/piwik/core/View.php:241]
#14 Piwik\View->renderTwigTemplate(...) called at [/html/piwik/core/View.php:236]
#15 Piwik\View->render(...) called at [/html/piwik/core/Plugin/ViewDataTable.php:255]
#16 Piwik\Plugin\ViewDataTable->render(...) called at [/html/piwik/core/ViewDataTable/Factory.php:123]
#17 Piwik\ViewDataTable\Factory::renderReport(...) called at [/html/piwik/plugins/Live/Controller.php:99]
#18 Piwik\Plugins\Live\Controller->getLastVisitsDetails(...) called at [/html/piwik/plugins/Live/Controller.php:93]
#19 Piwik\Plugins\Live\Controller->indexVisitorLog(...) called at [:]
#20 call_user_func_array(...) called at [/html/piwik/core/FrontController.php:114]
#21 Piwik\FrontController->dispatch(...) called at [/html/piwik/index.php:56]

@tsteur
Copy link
Member

tsteur commented Oct 31, 2013

Cool! That already helps us.

Can you executephp composer.phar update in your Piwik directory to get the latest Twig updates and then tell us again in which line it fails?

We don't need the backtrace. Just this message is enough:

Warning: htmlspecialchars() [function.htmlspecialchars]: Invalid multibyte sequence in argument in /html/piwik/vendor/twig/twig/lib/Twig/Extension/Core.php on line 927

Thx a lot for your help!

@hpvd
Copy link
Author

hpvd commented Oct 31, 2013

stupid question because I'm no programmer:
how to do "execute "php composer.phar update"" ?
Made & call a file test.php ? and put what exactly inside?

@tsteur
Copy link
Member

tsteur commented Oct 31, 2013

ah sorry, I thought you are maybe familiar with this. No worries, we will release another beta soon and maybe you can just use the Piwik Update feature from the UI to upgrade? That also does the trick and is easier.

@tsteur
Copy link
Member

tsteur commented Nov 5, 2013

Hi, FYI: beta 3 is now available

@hpvd
Copy link
Author

hpvd commented Nov 5, 2013

Hi, thanks for the information. I regularly copy the latest version from github master to my account, so no update was found today.
The warning line 927 still keeps the same...

@mattab
Copy link
Member

mattab commented Nov 5, 2013

your files have not updated properly, becuase the line 927 does not have such function in the 2.0-beta 3 zip, make sure all files are really overwritten

@hpvd
Copy link
Author

hpvd commented Nov 5, 2013

thanks for your info. So I don't do the GUI update as before (which shows "no new version") but take the file piwik-2.0-b3.zip from http://builds.piwik.org/ and put it on my server:

New Message:
There is an error. Please report the message (Piwik 2.0-b3) and full backtrace in the Piwik forums (please do a Search first as it might have been reported already!).

Warning: htmlspecialchars() [function.htmlspecialchars]: Invalid multibyte sequence in argument in /html/piwik/vendor/twig/twig/lib/Twig/Extension/Core.php on line 942

@hpvd
Copy link
Author

hpvd commented Nov 8, 2013

just updated to latest piwik master from github

now its:
Warning: htmlspecialchars() [function.htmlspecialchars]: Invalid multibyte sequence in argument in /html/piwik/vendor/twig/twig/lib/Twig/Extension/Core.php on line 925

@tsteur
Copy link
Member

tsteur commented Nov 13, 2013

Hi hvpd,

unfortunately I can still not reproduce it. There must be a text which contains for instance a not correct encoded German umlaut. Do you always get this error?

Can you maybe try the following thing:

  • Open the file index.php from your Piwik installation
  • In line 52, before " if (!defined('PIWIK_ENABLE_DISPATCH') || PIWIK_ENABLE_DISPATCH) {", insert the following line:
error_reporting(0);```
* Reload the visitor log
* Do you see any missing text in any of the visitors? For instance a title of a link 
 * Open```
index.php``` again and remove the previously added line 

Please let us know whether you find anything or not. Maybe you can even send us a screenshot to hello (at) piwik.org ?

@hpvd
Copy link
Author

hpvd commented Nov 13, 2013

put "error_reporting(0);"

the error messages are gone

with your help I could now figure out the details:

of course piwik beta is running only on a testing website so there are not that many page views..

The error only occurs in visits from last month (october)
No errors in november anymore.
Maybe these visits have been processed with an older version of piwik (I constantly updated from github)? Is there a way to "reprocess" them?

switching the error messages off I could see at the places where the pagetitles have to been shown some empty rows.

You are right: these pagetitles contain german umlauts (,,...)
visiting these sites today again: the page titles are shown correctly without any errors !!

=> seems to be solved !!!!

many thanks!!

@tsteur
Copy link
Member

tsteur commented Nov 13, 2013

Cool, thx for letting us know!

It is not needed to reprocess the data as the VisitorLog does not use any archived data. Also the recorded data and the data structure did not change. Probably it was a bug in a previous master version. We take this issue seriously though and I will look into the code to look for some possible causes. I will let you know if I find something!

@mattab
Copy link
Member

mattab commented May 13, 2014

Invalid multibyte sequence in argument in /html/piwik/vendor/twig/twig/lib/Twig/Extension/Core.php on line 927

This bug has occurred again in Piwik 2.2.2. I created ticket at #5157

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

3 participants