@ksubileau opened this Pull Request on March 17th 2013 Contributor

A first implementation of the new feature requested in #3697.
It might be better to export the array of ISP names in a separate file (in the core/DataFiles folder, as it's done for search engines or countries for example), what do you think about it?

Note that I'm the same person as "bugmenot" (the author of the ticket), but with a new github account and my real name this time ;-)

@mattab commented on March 17th 2013 Member

Thanks for the pull request, it looks good!
just one suggestion:

  • can you move the "Providers" array to its own core/DataFiles/Providers.php following others' patterns.
@halfdan commented on March 19th 2013 Member

@ksubileau, nice changes, this looks good. Right now the build is failing (see https://travis-ci.org/piwik/piwik/builds/5573318). Can you please take a look at this since it seems it's related to your PR.

@pebosi commented on March 20th 2013 Contributor

As an alternative method we could use "GeoLite ASN" list to get ISP names.

@mattab commented on April 2nd 2013 Member

Nice! I would merge it, but it says " This pull request cannot be automatically merged. "

@mattab commented on April 2nd 2013 Member

Also, you could rename other functions Piwik_X to Piwik_Provider_X to follow your pattern

@halfdan commented on April 2nd 2013 Member

@mattab, we can do that in the 2.x cleanup.
Thanks @ksubileau for the pull request! I merged your changes. Now we just need to add more providers to the list.

This Pull Request was closed on April 2nd 2013
Powered by GitHub Issue Mirror