Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sparkline library with jquery.Sparklines #4198

Closed
halfdan opened this issue Oct 7, 2013 · 2 comments
Closed

Replace sparkline library with jquery.Sparklines #4198

halfdan opened this issue Oct 7, 2013 · 2 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@halfdan
Copy link
Member

halfdan commented Oct 7, 2013

The sparkline library that is used to render sparklines on the MultiWebsite Dashboard could be replaced by jquery.Sparklines.

http://omnipotent.net/jquery.sparkline/#s-about

This would mean we could get rid of the GD dependency and enhance the sparklines with additional information. We could also re-use the evolution data to render the sparklines on the MultiWebsite dashboard.

@sgiehl
Copy link
Member

sgiehl commented Oct 7, 2013

We need to keep in mind that it still needs to be possible to render those sparklines without javascript as they are shown in piwik mobile I think. Maybe the Imagegraph plugin should be able to handle that.

Btw. isn't there a posibillity to render sparklines with jqplot. Would be a better solution to use that instead of adding another external library.

@mattab
Copy link
Member

mattab commented Oct 7, 2013

This lib looks awesome!

couple notes though:

  • We wouldn't get rid of GD since ImageGraphs uses GD to generate graphs for email reports and Piwik Mobile.
  • Stefan makes a good point that having GD version of sparklines is useful, since it could provide sparklines for email reports and Piwik mobile.

@halfdan halfdan added this to the Future releases milestone Jul 8, 2014
@mattab mattab modified the milestones: Long term, Mid term Dec 23, 2015
@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
@sgiehl sgiehl closed this as completed Nov 18, 2017
@sgiehl sgiehl added the wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it. label Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

No branches or pull requests

3 participants