Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Submodule easier to use #4196

Closed
mattab opened this issue Oct 5, 2013 · 0 comments
Closed

Make Submodule easier to use #4196

mattab opened this issue Oct 5, 2013 · 0 comments
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. worksforme The issue cannot be reproduced and things work as intended.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Oct 5, 2013

We use submodules to keep track of Core plugins which are in their own repositories. We also use submodule for the UI screenshot tests.

I update all submodules with:

git submodule foreach git pull origin master

A new feature of GIT could be useful to us: http://stackoverflow.com/questions/9189575/git-submodule-tracking-latest/9189815#9189815

When making changes in a submodule

cd plugins/TreemapVisualization
git checkout master
# make change
git push origin

Then tell piwik to track the updated version:

$ cd ../../
$ git add plugins/TreemapVisualization
$ git commit -m "useful msg here"
$ git push

We should document this in a dev page such as http://piwik.org/participate/development-process/

@mattab mattab added this to the 2.x - The Great Piwik 2.x Backlog milestone Jul 8, 2014
@mattab mattab closed this as completed May 2, 2016
@mattab mattab added the worksforme The issue cannot be reproduced and things work as intended. label Aug 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Development

No branches or pull requests

1 participant