Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up javascript code for tracking #418

Closed
pebosi opened this issue Nov 11, 2008 · 2 comments
Closed

Clean up javascript code for tracking #418

pebosi opened this issue Nov 11, 2008 · 2 comments
Labels
duplicate For issues that already existed in our issue tracker and were reported previously. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone

Comments

@pebosi
Copy link
Contributor

pebosi commented Nov 11, 2008

The current code is:

<!— Piwik
<a href=“http://piwik.org” title=“Web analytics api” onclick=“window.open(this.href);return(false);”>
<script type=“text/javascript”>
var pkBaseURL = ((“https:” == document.location.protocol) ? “https://xxx/” : “http://xxx/”);
document.write(unescape(“%3Cscript src=’” + pkBaseURL + “piwik.js’ type=‘text/javascript’%3E%3C/script%3E”));
</script><script type=“text/javascript”>
piwik_action_name = ’’;
piwik_idsite = 1;
piwik_url = pkBaseURL + “piwik.php”;
piwik_log(piwik_action_name, piwik_idsite, piwik_url);
</script>
<object><noscript><p>Web analytics api <img src=“http://xxx/piwik.php” style=“border:0” alt=“piwik”/></p></noscript></object></a>
<!
- End Piwik Tag —>

but i think it could be:

<!— Piwik
<script type=“text/javascript”>
var pkBaseURL = ((“https:” == document.location.protocol) ? “https://xxx/” : “http://xxx/”);
document.write(unescape(“%3Cscript src=’” + pkBaseURL + “piwik.js’ type=‘text/javascript’%3E%3C/script%3E”));
</script><script type=“text/javascript”>
piwik_action_name = ’’;
piwik_idsite = 1;
piwik_url = pkBaseURL + “piwik.php”;
piwik_log(piwik_action_name, piwik_idsite, piwik_url);
</script>
<noscript><img src=“http://xxx/piwik.php” style=“border:0;display:none” alt=“piwik”/></noscript>
<!
- End Piwik Tag —>

regards

@mattab
Copy link
Member

mattab commented Nov 24, 2008

Peter, we may investisgate this change when we work out the ticket #355
thanks for your feedback.

@robocoder
Copy link
Contributor

For XHTML validation, the <object> tag can’t be omitted because <noscript> is a block-level element.

@pebosi pebosi added this to the RobotRock milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate For issues that already existed in our issue tracker and were reported previously. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

3 participants