Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: Saving a website with an invalid IP address doesn't show an error #4144

Closed
halfdan opened this issue Sep 9, 2013 · 1 comment
Closed

regression: Saving a website with an invalid IP address doesn't show an error #4144

halfdan opened this issue Sep 9, 2013 · 1 comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
2.0

Comments

@halfdan
Copy link
Member

halfdan commented Sep 9, 2013

Saving a website with an invalid IP address doesn't show the error:

{"result":"error", "message":"The IP to exclude "asd" does not have a valid IP format (eg. 1.2.3.4, 1.2.3.*, or 1.2.3.4/5)."}

This seems to be a JavaScript regression.
@mattab
Copy link
Member

mattab commented Sep 18, 2013

this was fixed in git @ [https://github.com/piwik/piwik/commit/19e201afd35b541a96d8666ed463703abc3446df]

@halfdan halfdan added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@halfdan @mattab