Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bulk import API #4141

Closed
halfdan opened this issue Sep 8, 2013 · 6 comments
Closed

Bulk import API #4141

halfdan opened this issue Sep 8, 2013 · 6 comments
Assignees
@halfdan
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
2.0

Comments

@halfdan
Copy link
Member

halfdan commented Sep 8, 2013

The bulk import API is relatively hard to use right now:

  • When successful the transparent GIF is returned instead of a status message in JSON
  • When an error occurs because of an invalid token_auth a plain text message is returned (exitWithException isn't used in this case).
  • exitWithException doesn't set application/json header nor an appropriate status code
  • admin_token_auth is never set in UsersManager on loadWebsiteAttributes which makes it impossible for admin users to use bulk import
@anonymous-matomo-user
Copy link

In 1a6b565: Properly set admin_token_auth attribute for website attributes

refs #4141

@anonymous-matomo-user
Copy link

In f985d16: Properly catch exception on failed authentication for bulk import
Set correct header for application/json

refs #4141

@anonymous-matomo-user
Copy link

In 67c2973: Return JSON string on error in bulk tracking
Return JSON string with statistics on success

fixes #4141

@anonymous-matomo-user
Copy link

In 1ca9d90: Fix test for now changed bulk tracking response (valid JSON)

refs #4141

@anonymous-matomo-user
Copy link

In ccd81be: Fix stalling tests in ArchiveCronTest

refs #4141

@anonymous-matomo-user
Copy link

In 6765b82: Fix bulk tracking expected responses

refs #4141

@halfdan halfdan added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
@halfdan halfdan self-assigned this Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@halfdan
Properly set admin_token_auth attribute for website attributes
1a6b565 
refs matomo-org#4141
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@halfdan
Properly catch exception on failed authentication for bulk import
f985d16 
Set correct header for application/json

refs matomo-org#4141
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@halfdan
Return JSON string on error in bulk tracking
67c2973 
Return JSON string with statistics on success

fixes matomo-org#4141
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@halfdan
Fix test for now changed bulk tracking response (valid JSON)
1ca9d90 
refs matomo-org#4141
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@halfdan
Fix stalling tests in ArchiveCronTest
ccd81be 
refs matomo-org#4141
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@halfdan
Fix bulk tracking expected responses
6765b82 
refs matomo-org#4141
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@halfdan halfdan

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@halfdan @anonymous-matomo-user