@mattab opened this Issue on September 6th 2013 Member

Review hook names and make them consistent.

See suggestion in this doc https://docs.google.com/spreadsheet/ccc?key=0AvPareR6i0gfdFp4SUVNSy1qdE0zbTNhU3pRS0lLYnc#gid=0

@mattab commented on September 6th 2013 Member

In d91d0d861110f658c537c3103513d2a44f03d03b: * Renaming getCssFiles hook to getStylesheetFiles

  • Renaming function names
  • Removing getCss and getJs from CoreHome module since they are expected in the Proxy module

Refs #4134

@tsteur commented on October 1st 2013 Member

In e476ef097a7fa1b67c387fbeb2607f351293b0ec: refs #4134 renamed some hooks

@tsteur commented on October 1st 2013 Member

In 43883bda185a9f2d3053bec810bf3d73ad724629: refs #4134 renamed hook

@tsteur commented on October 1st 2013 Member

In 7b7df45145bf495c48590474e2e1e1c618a35e8f: refs #4134 better name for constant after renaming the hook

@tsteur commented on October 1st 2013 Member

In 7abaeb935f04b5c983289c2fd85d7763c6977029: refs #4134 renamed template hooks

@tsteur commented on October 1st 2013 Member

In 676327fd96735d2749829c5eae0f16dbe04dda90: refs #4134 trigger general API event for all actions

@tsteur commented on October 1st 2013 Member

In c19465f048da14d8bdb72b642a1d1c5871ac69bd: refs #4134 added general event for controllers

@tsteur commented on October 1st 2013 Member

In 2c5e854984ab6e989d41d366b961953fbb2defee: refs #4134 renamed some more hooks

@tsteur commented on October 1st 2013 Member

In f00d2f87b8b2c6a45e38c0c4eb5fd90eb919974b: refs #4134 use plural to indicate a developer can add multiple entries or widgets

@tsteur commented on October 2nd 2013 Member

In cc422d3f666e4b4b87037499ee8b27609d1481b5: refs #4134 added generic API hook

@tsteur commented on October 2nd 2013 Member

In f185beba0491c1f72f84d71d9c69cb11d75b0a6d: refs #4134 renamed some more hooks and removed some not used and not needed hooks

@halfdan commented on October 2nd 2013 Member

Is there a list of changed hooks? This would be important to have since people need to rewrite their plugins.

@tsteur commented on October 3rd 2013 Member

new: API.Request.dispatch
API.Proxy.processReturnValue --> API.Request.dispatch.end
ArchiveProcessing_Day.compute --> ArchiveProcessor.Day.compute
ArchiveProcessing_Period.compute --> ArchiveProcessor.Period.compute
AssetManager.filterMergedJs --> AssetManager.filterMergedJavaScripts
AssetManager.filterMergedCss --> AssetManager.filterMergedStylesheets
AssetManager.getJsFiles --> AssetManager.getJavaScriptFiles
FrontController.badConfigurationFile --> Config.badConfigurationFile
FrontController.NoConfigurationFile --> Config.noConfigurationFile
AdminMenu.add --> Menu.Admin.addItems
Menu.add --> Menu.Reporting.addItems
TopMenu.add --> Menu.Top.addItems
FrontController.dispatch --> Request.dispatch
new: Request.dispatch.end
FrontController.dispatchCoreAndPluginUpdatesScreen --> Request.dispatchCoreAndPluginUpdatesScreen
FrontController.initAuthenticationObject --> Request.initAuthenticationObject
Piwik.getKnownSegmentsToArchiveAllSites --> Segments.getKnownSegmentsToArchiveAllSites
Piwik.getKnownSegmentsToArchiveForSite --> Segments.getKnownSegmentsToArchiveForSite
Common.fetchWebsiteAttributes --> Site.getSiteAttributes
SitesManager.deleteSite --> SitesManager.deleteSite.end
template_footerUserCountry --> Template.footerUserCountry
template_footerVisitsFrequency --> Template.footerVisitsFrequency
template_headerVisitsFrequency --> Template.headerVisitsFrequency
template_leftColumnUserCountry --> Template.leftColumnUserCountry
template_nextToCalendar --> Template.nextToCalendar
template_reportParametersPDFReports --> Template.reportParametersPDFReports
template_topBar --> Template.topBar
Tracker.detectRefererSearchEngine --> Tracker.detectReferrerSearchEngine
Tracker.Visit.isExcluded --> Tracker.isExcludedVisit
Tracker.Action.record --> Tracker.recordAction
Tracker.setRequest.idSite --> Tracker.setSiteId
Tracker.Visit.setVisitorIp --> Tracker.setVisitorIp
Tracker.saveVisitorInformation --> Tracker.visitorInformation
FrontController.checkForUpdates --> Updater.checkForUpdates
Translate.getLanguageToLoad --> User.getLanguage
FrontController.NoAccessException --> User.isNotAuthorized
ViewDataTable.Visualization.getAvailable --> Visualization.addVisualizations
ViewDataTable.configureFooterIcons --> Visualization.configureFooterIcons
ViewDataTable.getReportDisplayProperties --> Visualization.getReportDisplayProperties
ViewDataTable.configureReportView --> Visualization.initView
WidgetsList.add --> WidgetsList.addWidgets
WidgetsList.get --> WidgetsList.getWidgets

@mattab commented on October 7th 2013 Member

See also next step: #4199 Document Hook events

@tsteur commented on October 9th 2013 Member
This Issue was closed on November 21st 2013
Powered by GitHub Issue Mirror