Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review list of Event names, Piwik 2 plugin hooks #4134

Closed
mattab opened this issue Sep 6, 2013 · 15 comments
Closed

Review list of Event names, Piwik 2 plugin hooks #4134

mattab opened this issue Sep 6, 2013 · 15 comments
Assignees
@tsteur
Labels
Critical Indicates the severity of an issue is very critical and the issue has a very high priority. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.0

Comments

@mattab
Copy link
Member

mattab commented Sep 6, 2013

Review hook names and make them consistent.

See suggestion in this doc https://docs.google.com/spreadsheet/ccc?key=0AvPareR6i0gfdFp4SUVNSy1qdE0zbTNhU3pRS0lLYnc#gid=0
@mattab
Copy link
Member Author

mattab commented Sep 6, 2013

In d91d0d8: * Renaming getCssFiles hook to getStylesheetFiles

  • Renaming function names
  • Removing getCss and getJs from CoreHome module since they are expected in the Proxy module

Refs #4134

@tsteur
Copy link
Member

tsteur commented Oct 1, 2013

In e476ef0: refs #4134 renamed some hooks

@tsteur
Copy link
Member

tsteur commented Oct 1, 2013

In 43883bd: refs #4134 renamed hook

@tsteur
Copy link
Member

tsteur commented Oct 1, 2013

In 7b7df45: refs #4134 better name for constant after renaming the hook

@tsteur
Copy link
Member

tsteur commented Oct 1, 2013

In 7abaeb9: refs #4134 renamed template hooks

@tsteur
Copy link
Member

tsteur commented Oct 1, 2013

In 676327f: refs #4134 trigger general API event for all actions

@tsteur
Copy link
Member

tsteur commented Oct 1, 2013

In c19465f: refs #4134 added general event for controllers

@tsteur
Copy link
Member

tsteur commented Oct 1, 2013

In 2c5e854: refs #4134 renamed some more hooks

@tsteur
Copy link
Member

tsteur commented Oct 1, 2013

In f00d2f8: refs #4134 use plural to indicate a developer can add multiple entries or widgets

@tsteur
Copy link
Member

tsteur commented Oct 2, 2013

In cc422d3: refs #4134 added generic API hook

@tsteur
Copy link
Member

tsteur commented Oct 2, 2013

In f185beb: refs #4134 renamed some more hooks and removed some not used and not needed hooks

@halfdan
Copy link
Member

halfdan commented Oct 2, 2013

Is there a list of changed hooks? This would be important to have since people need to rewrite their plugins.

@tsteur
Copy link
Member

tsteur commented Oct 3, 2013

new: API.Request.dispatch
API.Proxy.processReturnValue --> API.Request.dispatch.end
ArchiveProcessing_Day.compute --> ArchiveProcessor.Day.compute
ArchiveProcessing_Period.compute --> ArchiveProcessor.Period.compute
AssetManager.filterMergedJs --> AssetManager.filterMergedJavaScripts
AssetManager.filterMergedCss --> AssetManager.filterMergedStylesheets
AssetManager.getJsFiles --> AssetManager.getJavaScriptFiles
FrontController.badConfigurationFile --> Config.badConfigurationFile
FrontController.NoConfigurationFile --> Config.noConfigurationFile
AdminMenu.add --> Menu.Admin.addItems
Menu.add --> Menu.Reporting.addItems
TopMenu.add --> Menu.Top.addItems
FrontController.dispatch --> Request.dispatch
new: Request.dispatch.end
FrontController.dispatchCoreAndPluginUpdatesScreen --> Request.dispatchCoreAndPluginUpdatesScreen
FrontController.initAuthenticationObject --> Request.initAuthenticationObject
Piwik.getKnownSegmentsToArchiveAllSites --> Segments.getKnownSegmentsToArchiveAllSites
Piwik.getKnownSegmentsToArchiveForSite --> Segments.getKnownSegmentsToArchiveForSite
Common.fetchWebsiteAttributes --> Site.getSiteAttributes
SitesManager.deleteSite --> SitesManager.deleteSite.end
template_footerUserCountry --> Template.footerUserCountry
template_footerVisitsFrequency --> Template.footerVisitsFrequency
template_headerVisitsFrequency --> Template.headerVisitsFrequency
template_leftColumnUserCountry --> Template.leftColumnUserCountry
template_nextToCalendar --> Template.nextToCalendar
template_reportParametersPDFReports --> Template.reportParametersPDFReports
template_topBar --> Template.topBar
Tracker.detectRefererSearchEngine --> Tracker.detectReferrerSearchEngine
Tracker.Visit.isExcluded --> Tracker.isExcludedVisit
Tracker.Action.record --> Tracker.recordAction
Tracker.setRequest.idSite --> Tracker.setSiteId
Tracker.Visit.setVisitorIp --> Tracker.setVisitorIp
Tracker.saveVisitorInformation --> Tracker.visitorInformation
FrontController.checkForUpdates --> Updater.checkForUpdates
Translate.getLanguageToLoad --> User.getLanguage
FrontController.NoAccessException --> User.isNotAuthorized
ViewDataTable.Visualization.getAvailable --> Visualization.addVisualizations
ViewDataTable.configureFooterIcons --> Visualization.configureFooterIcons
ViewDataTable.getReportDisplayProperties --> Visualization.getReportDisplayProperties
ViewDataTable.configureReportView --> Visualization.initView
WidgetsList.add --> WidgetsList.addWidgets
WidgetsList.get --> WidgetsList.getWidgets

@mattab
Copy link
Member Author

mattab commented Oct 7, 2013

See also next step: #4199 Document Hook events

@tsteur
Copy link
Member

tsteur commented Oct 9, 2013

A list of hooks is also available here: https://github.com/piwik/plugins-api-doc-generator/blob/master/docs/Hooks.md

@mattab mattab added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
@mattab mattab mentioned this issue Feb 23, 2014
Closed
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
* Renaming getCssFiles hook to getStylesheetFiles
d91d0d8 
* Renaming function names
* Removing getCss and getJs from CoreHome module since they are expected in the Proxy module

Refs matomo-org#4134
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4134 renamed some hooks
e476ef0
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4134 renamed hook
43883bd
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4134 better name for constant after renaming the hook
7b7df45
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4134 renamed template hooks
7abaeb9
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4134 trigger general API event for all actions
676327f
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4134 added general event for controllers
c19465f
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4134 renamed some more hooks
2c5e854
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4134 use plural to indicate a developer can add multi…
f00d2f8 
…ple entries or widgets
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4134 added generic API hook
cc422d3
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4134 renamed some more hooks and removed some not use…
f185beb 
…d and not needed hooks
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Critical Indicates the severity of an issue is very critical and the issue has a very high priority. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
3 participants
@halfdan @tsteur @mattab