@halfdan opened this Issue on September 3rd 2013 Member

We can clean the code base after raising the requirement to PHP 5.3.

There are some compat functions in core/IP.php because Windows with PHP < 5.3 did not provide inet_ntop/inet_pton.

@anonymous-matomo-user commented on September 3rd 2013

In 3f7a6795f1c61076bbd70720c5950fabf9bcddde: Remove compat code for PHP < 5.3. inet_pton/inet_ntop are available in Windows in PHP >= 5.3 so we don't need the compat code anymore.

refs #3741, #4113

@anonymous-matomo-user commented on September 3rd 2013

In d507de9e798db4502730fa4e04a321cadfbec6ed: Remove more pre 5.3 compat code

refs #4113

@anonymous-matomo-user commented on September 4th 2013

In d2e842fbc3c70a7e2264ad978d1e36798f24a8a6: Remove upgradephp library

refs #4113

@halfdan commented on September 4th 2013 Member

Reverted the last commit. upgradephp should be merged with core somehow. We don't need to upgrade some of the functions anymore.

Any reason for #1900? What's the point of not unserializing objects - as long as we don't execute anything we should be safe, right?

@anonymous-matomo-user commented on September 4th 2013

In f229dbc8cc1df2fbe90bdcd5a9e7762abc5fc8ae: Replace create_function calls with lambda functions.
This allows the IDE to pick up all code!

refs #4113

@robocoder commented on September 5th 2013 Contributor
@halfdan commented on September 5th 2013 Member

@vipsoft: Thanks for the info!

@mattab commented on September 6th 2013 Member

Good to get it done for 2.0.

What is left on this ticket?

@halfdan commented on September 6th 2013 Member

We need to check what we need from libs/upgradephp - there are some patches that Anthon mentioned above, but also some code that could be removed. So maybe we could merge the remainders into core.

There are also some functions in core (e.g. IP::N2P etc.) that could be removed.

@mattab commented on September 6th 2013 Member

Could you simply list all functions you think should be deleted, in the ticket description, and I'll investigate for sure.

This Issue was closed on October 9th 2013
Powered by GitHub Issue Mirror