Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make JavaScript code modular by introducing simple 'require(...') function #4100

Closed
diosmosis opened this issue Aug 27, 2013 · 3 comments
Closed

Make JavaScript code modular by introducing simple 'require(...') function #4100

diosmosis opened this issue Aug 27, 2013 · 3 comments
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. worksforme The issue cannot be reproduced and things work as intended.
Milestone
Long term

Comments

@diosmosis
Copy link
Member

Adding our own simple require(...) function will make it easier to keep the 'window' object clean, make our code clearer and will allow 3rd plugin developers to avoid cluttering the 'window' object.
@anonymous-matomo-user
Copy link

In ed0f3d2: Refs #4100, #4041, #4077, add minimal UI module inclusion/creation function and use for SeriesPicker. Also includes a documentation correction for SeriesPicker.

@anonymous-matomo-user
Copy link

In 6aa3a44: Refs #4100, #4041, #4077, fix docs in last commit.

@mattab
Copy link
Member

mattab commented Jan 10, 2014

@capedfuzz Is this ticket fixed what is left?

@diosmosis diosmosis added this to the 2.x - The Great Piwik 2.x Backlog milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4100, matomo-org#4041, matomo-org#4077, add minimal U…
ed0f3d2 
…I module inclusion/creation function and use for SeriesPicker. Also includes a documentation correction for SeriesPicker.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4100, matomo-org#4041, matomo-org#4077, fix docs in l…
6aa3a44 
…ast commit.
@mattab mattab closed this as completed Oct 11, 2014
@mattab mattab added the worksforme The issue cannot be reproduced and things work as intended. label Oct 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Milestone
Long term
Development

No branches or pull requests
3 participants
@diosmosis @mattab @anonymous-matomo-user