Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Plugin DBStats hooks into every single ViewDataTable creation on all reports #4089

Closed
peterbo opened this issue Aug 19, 2013 · 1 comment
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Milestone

Comments

@peterbo
Copy link
Contributor

peterbo commented Aug 19, 2013

At the moment, the DBStats Plugin hooks into the "ViewDataTable.getReportDisplayProperties" hook and adds its properties to every single DataTable within Piwik. This is unnessesary and could lead to unexpected behaviour and harms performance.

The DBStats Plugin should only hook into DataTables when its reports are shown.

@diosmosis
Copy link
Member

No longer relevant.

@peterbo peterbo added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
@mattab mattab added the wontfix label Aug 3, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

No branches or pull requests

3 participants