Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client side encryption of user password #4080

Closed
mattab opened this issue Aug 15, 2013 · 5 comments
Closed

Client side encryption of user password #4080

mattab opened this issue Aug 15, 2013 · 5 comments
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@mattab
Copy link
Member

mattab commented Aug 15, 2013

We could encrypt the password, after it has been submitted in the login form, so that the password is not sent in the clear.

eg. http://code.google.com/p/crypto-js/#Quick-start_Guide

@mattab
Copy link
Member Author

mattab commented Jan 10, 2014

that's a nice idea, but you can already use SSL in Piwik: http://piwik.org/faq/how-to/faq_91/

@mattab mattab added this to the Future releases milestone Jul 8, 2014
@mattab mattab removed the P: normal label Aug 3, 2014
@martin-ueding
Copy link

Sounds like a slight improvement if the traffic is only sniffed. If you have a man-in-the-middle, Eve could just change the action of the form or inject a JavaScript keylogger. TLS is the only meaningful way to secure the login credentials, since the auth cookie could still be stolen.

@mattab
Copy link
Member Author

mattab commented Sep 20, 2014

yes it's only a slight improvement, what it helps is a user prevent someone reading the actual plain password string. But TLS should be used instead for sure. I'll close this ticket for now, if you disagree please comment!

@mattab mattab closed this as completed Sep 20, 2014
@mattab mattab added the wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it. label Sep 20, 2014
@martin-ueding
Copy link

I think it is fine to close this and focus on more important things. Piwik will benefit from having a stronger hashing algorithm and TLS on the installation site than to give the user a false feeling of security against attackers that for some reason only decide to listen to the authentication phase (and not the cookie).

@mattab
Copy link
Member Author

mattab commented Sep 20, 2014

Cheers, I love adding wontfix to issues, wish we could do it more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

No branches or pull requests

2 participants