Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little error in isValidUrl, rejecting "~" #403

Closed
anonymous-matomo-user opened this issue Oct 28, 2008 · 2 comments
Closed

Little error in isValidUrl, rejecting "~" #403

anonymous-matomo-user opened this issue Oct 28, 2008 · 2 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@anonymous-matomo-user
Copy link

Hi, “~” is common in personal webpages on UNIX, should be accepted too:


plugins/SitesManager/API.php.orig 2008-06-26 01:57:04.000000000 +0200

+ plugins/SitesManager/API.php 2008-10-28 10:36:03.000000000 +0100
@ -447,7 +447,7 @
/
static private function isValidUrl( $url )
{
- return ereg(’^http[s]?://([A-Za-z0-9\/_.:-])
$‘, $url);
- ```
return ereg(’^http[s]?://([A-Za-z0-9\/_.:-~])*$’, $url);
}

/** ```
@anonymous-matomo-user
Copy link
Author

Sorry, better formatted:

```
- API.php.orig 2008-06-26 01:57:04.000000000 0200
+
+ API.php 2008-10-28 10:36:03.000000000 +0100
@ -447,7 +447,7 @
/
static private function isValidUrl( $url )
{
- return ereg(’^http[s]?://([A-Za-z0-9\/_.:-])
$‘, $url);
+ return ereg(’^http[s]?://([A-Za-z0-9\/_.:-~])*$’, $url);
}

/**

```

@mattab
Copy link
Member

mattab commented Oct 28, 2008

already fixed in svn :) thx

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

2 participants