Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt-out/in iframe code is not following HTML standard #4022

Closed
anonymous-matomo-user opened this issue Jun 25, 2013 · 7 comments
Closed

Opt-out/in iframe code is not following HTML standard #4022

anonymous-matomo-user opened this issue Jun 25, 2013 · 7 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@anonymous-matomo-user
Copy link

It looks like this:

<iframe frameborder="no" width="600px" height="200px" src="http://foo.bar/index.php?module=CoreAdminHome&action=optOut&language=en"></iframe>

But should looks like this:

<iframe frameborder="no" width="600" height="200" src="http://foo.bar/index.php?module=CoreAdminHome&action=optOut&language=en"></iframe>

Because there are "pixels by default", values of those attributes should be just numbers. See http://www.w3.org/TR/html4/present/frames.html#h-16.5 or try to validate this code in validator.nu, you will get info that "p" after 200 and 600 is not a number.

That code could even look like:

<iframe style="border: 0; height: 200x; width: 600px" src="http://foo.bar/index.php?module=CoreAdminHome&action=optOut&language=en"></iframe>

Because it's good to use CSS for presentation, even in-line, and frameborder attribute is obsolete in HTML5.
Keywords: html, css, opt-out

@anonymous-matomo-user
Copy link
Author

Of course last code should be:

<iframe style="border: 0; height: 200px; width: 600px" src="http://foo.bar/index.php?module=CoreAdminHome&action=optOut&language=en"></iframe>

Sorry, I was fighting with time to not be logged out again before clicking "Create ticket"

@mattab
Copy link
Member

mattab commented Aug 9, 2013

Please can you propose pull request? http://piwik.org/participate/contributing-with-git/

@anonymous-matomo-user
Copy link
Author

In 1828305: Fix iframe width/height

fixes #4022
skip

@anonymous-matomo-user
Copy link
Author

In 1404802: refs #4022

@sgiehl
Copy link
Member

sgiehl commented Aug 15, 2013

In e7108e6: refs #4022 fixed typo

@anonymous-matomo-user
Copy link
Author

In 770fd36: refs #4022 Fix iframe attributes in privacy settings

Original fix was only applied to plugins/CoreAdminHome/templates/generalSettings.twig.

@mattab
Copy link
Member

mattab commented Mar 30, 2014

In 013f3a2: Merge pull request #253 from fhemberger/fix-optout-iframe

refs #4022 Fix iframe attributes in privacy settings

@anonymous-matomo-user anonymous-matomo-user added this to the 2.x - The Great Piwik 2.x Backlog milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Original fix was only applied to `plugins/CoreAdminHome/templates/generalSettings.twig`.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

4 participants