@anonymous-matomo-user opened this Issue on June 25th 2013

It looks like this:

<iframe frameborder="no" width="600px" height="200px" src="http://foo.bar/index.php?module=CoreAdminHome&action=optOut&language=en"></iframe>

But should looks like this:

<iframe frameborder="no" width="600" height="200" src="http://foo.bar/index.php?module=CoreAdminHome&action=optOut&language=en"></iframe>

Because there are "pixels by default", values of those attributes should be just numbers. See http://www.w3.org/TR/html4/present/frames.html#h-16.5 or try to validate this code in validator.nu, you will get info that "p" after 200 and 600 is not a number.

That code could even look like:

<iframe style="border: 0; height: 200x; width: 600px" src="http://foo.bar/index.php?module=CoreAdminHome&action=optOut&language=en"></iframe>

Because it's good to use CSS for presentation, even in-line, and frameborder attribute is obsolete in HTML5.
Keywords: html, css, opt-out

@anonymous-matomo-user commented on June 25th 2013

Of course last code should be:

<iframe style="border: 0; height: 200px; width: 600px" src="http://foo.bar/index.php?module=CoreAdminHome&action=optOut&language=en"></iframe>

Sorry, I was fighting with time to not be logged out again before clicking "Create ticket"

@mattab commented on August 9th 2013 Member

Please can you propose pull request? http://piwik.org/participate/contributing-with-git/

@anonymous-matomo-user commented on August 15th 2013

In 18283051374f8b5c56d65f66b715d630b29d35f1: Fix iframe width/height

fixes #4022

@anonymous-matomo-user commented on August 15th 2013

In 14048028ea84c3aa4036fc0ea80217798c876d04: refs #4022

@sgiehl commented on August 15th 2013 Member

In e7108e6d6bf3c8f5b3ac588cf092f4df6496add6: refs #4022 fixed typo

@anonymous-matomo-user commented on March 30th 2014

In 770fd36b6f19eab2bef96312b1720c652055629b: refs #4022 Fix iframe attributes in privacy settings

Original fix was only applied to plugins/CoreAdminHome/templates/generalSettings.twig.

@mattab commented on March 30th 2014 Member

In 013f3a27c846cba36d2e96ac0d73fb47cd0b4b5a: Merge pull request #253 from fhemberger/fix-optout-iframe

refs #4022 Fix iframe attributes in privacy settings

This Issue was closed on March 30th 2014
Powered by GitHub Issue Mirror