Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PDF Reports Truncation limit configurable in config file #4009

Closed
timo-bes opened this issue Jun 13, 2013 · 2 comments
Closed

Make PDF Reports Truncation limit configurable in config file #4009

timo-bes opened this issue Jun 13, 2013 · 2 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
2.0

Comments

@timo-bes
Copy link
Member

In Piwik_PDFReports_API.generateReport, $_GET['filter_truncate'] is set to self::REPORT_TRUNCATE = 23.

The comment is:

the report will be rendered with the first 23 rows and will aggregate other rows in a summary row
23 rows table fits in one portrait page

There are two problems with this

  • People might want more than 23 rows in their PDF reports
  • The truncation in not necessary when rendering a HTML report or a portrait page
@timo-bes
Copy link
Member Author

In 668111b: refs #4009 making the number of rows after which the PDFReports plugin truncates configurable.

this does not fix the ticket since it still would be nice if the truncation would be a little more intelligent. i.e. using different values for landscape / portrait and/or not truncating at all in HTML view.

julien, if you disagree, feel free to close the ticket. it's just a suggestion and i fixed the part that caused trouble for me so i'm fine either way.

@mattab
Copy link
Member

mattab commented Aug 9, 2013

Narrowing scope, it's fixed!

@timo-bes timo-bes added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@timo-bes @mattab