New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect define() signature #3975
Comments
This issue breaks existing websites that use RequireJS when Piwik is loaded async (which it is by default).
When piwik.js is evaluated before require.js, this stops loading other modules, instead of giving only an error. Perhaps it is a good idea to release Piwik 1.12.1 with the provided fix? |
Already committed to the 1.x maintenance branch. |
bug still present in current 1.12 - had to patch manually |
Can you confirm it works in 2.0 ? https://piwik.org/blog/2013/10/new-piwik-2-0-public-beta-for-testers/ If not please suggest how to fix it, cheers |
It's fixed. Thanks. |
piwik.js
change:
to:
The module name should not be wrapped in brackets. It should be passed as a string; not an array.
Keywords: define amd
The text was updated successfully, but these errors were encountered: