Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code shouldnt use _GET and _POST directly but fetch them via a helper method #3931

Closed
mattab opened this issue May 11, 2013 · 2 comments
Closed
Labels
duplicate For issues that already existed in our issue tracker and were reported previously. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.

Comments

@mattab
Copy link
Member

mattab commented May 11, 2013

AS part of #2135 I discovered the joy of inconsistencies between browsers (Firefox decodes URL hash, while others don't) and inconsistencies in PHP (_GET is URL decoded by default, so we can use _SERVER[QUERY_STRING] to access raw value.

To prevent further problems in the future and keep other devs from experiencing my pain, I'd like to change the codebase so that no one uses _GET or _POST directly but always ask a helper method.

@mattab
Copy link
Member Author

mattab commented May 12, 2013

In 263892f: Refs #2135

@michalkleiner
Copy link
Contributor

Closing as superseded by #12620

@michalkleiner michalkleiner added the duplicate For issues that already existed in our issue tracker and were reported previously. label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate For issues that already existed in our issue tracker and were reported previously. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

2 participants