Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression Row Evolution - broken filter_limit #3897

Closed
julienmoumne opened this issue Apr 15, 2013 · 3 comments
Closed

regression Row Evolution - broken filter_limit #3897

julienmoumne opened this issue Apr 15, 2013 · 3 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@julienmoumne
Copy link
Member

When specifying both filter_limit and filter_sort_column, filter_limit is broken.

In the following example, filter_limit is set to 5 but 9 results are returned :http://demo.piwik.org/index.php?module=API&method=API.getRowEvolution&idSite=7&period=day&date=previous4&apiModule=Goals&apiAction=getDaysToConversion&filter_limit=5&filter_sort_column=nb_conversions

However, it works if filter_sort_column is not specified as in : http://demo.piwik.org/index.php?module=API&method=API.getRowEvolution&idSite=7&period=day&date=previous4&apiModule=Goals&apiAction=getDaysToConversion&filter_limit=5

@diosmosis
Copy link
Member

Hi Julien, can I ask is your use case for using filter_limit doing multi row evolution w/o specifying labels? I think filter_limit has no meaning when labels are specified since the labels are what determine how many results are returned.

@mattab
Copy link
Member

mattab commented Apr 16, 2013

it will be only when &labels is not specified, like you say it does not make sense to specify filter_limit and labels.

@diosmosis
Copy link
Member

In c91a603: Fixes #3897, make sure filter_limit limits the number of labels returned when no labels are specified with multi-row evolution and make sure it has no effect in all other row evolution cases.

@julienmoumne julienmoumne added this to the 1.12 - The Great 1.x Backlog milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

3 participants